Sign upLogin

e-ucm/js-tracker

View on GitHub
Star

Showing 45 of 45 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

         function (data) {
            if (tracker.settings.debug && data.responseJSON) {
                console.log(data.responseJSON);
            }
            callback(data, true);
Severity: Minor
Found in src/js-tracker.js and 1 other location - About 55 mins to fix
src/js-tracker.js on lines 127..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                        if (ismap(this.Extensions[key])) {
                            var smap = '';

                            for (var k in this.Extensions[key]) {
                                if (typeof this.Extensions[key][k] === 'number') {
Severity: Major
Found in src/js-tracker.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                                    if (error && tracker.queue.length > 0) {
                                    tracker.tracesPending.push(data);
                                    callback('Can\'t send Traces', true);
                                }else {
                                    callback('Everything OK', false);
    Severity: Major
    Found in src/js-tracker.js - About 45 mins to fix

      Function HttpRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          this.HttpRequest = function(url, method, headers, body, success, error) {
      Severity: Minor
      Found in src/js-tracker.js - About 45 mins to fix

        Function Looked has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    this.Looked = function(placeId, type, orientation, latitude, longitude) {
        Severity: Minor
        Found in plugins/geolocation.js - About 35 mins to fix
          Severity
          Category
          Status
          Source
          Language