e107inc/e107

File admin_ui.php has 5070 lines of code (exceeds 2000 allowed). Consider refactoring.

Open

<?php
/*
 * e107 website system
 *
 * Copyright (C) 2008-2012 e107 Inc (e107.org)

Method _modifyListQrySearch has 16 arguments (exceeds 7 allowed). Consider refactoring.

Open

    public function _modifyListQrySearch($listQry, $searchTerm, $filterOptions, string $tablePath,  string $tableFrom, string $primaryName, $raw, $orderField, $qryAsc, $forceFrom, int $qryFrom, $forceTo, int $perPage, $qryField,  $isfilter, $handleAction)

Consider simplifying this complex logical expression.

Open

        if($field['type'] === 'method' && !empty($field['data']) && ($field['data'] === 'string' || $field['data'] === 'str' || $field['data'] === 'safestr' || $field['data'] === 'int'))
        {
            $searchable_types[] = 'method';
        }

Avoid too many return statements within this method.

Open

                        return $this;

Avoid too many return statements within this method.

Open

                    return $this;

Avoid too many return statements within this method.

Open

                    return $this;

Avoid too many return statements within this method.

Open

        return $this;

Avoid too many return statements within this method.

Open

                    return $this;

Avoid too many return statements within this method.

Open

                    return $this;

Avoid too many return statements within this method.

Open

                    return $this;

Avoid too many return statements within this method.

Open

        return false;

Avoid too many return statements within this method.

Open

                    return $this;

Argument 3 (exclude_query) is true but \e_admin_controller::redirect() takes array|string defined at /code/e107_handlers/admin_ui.php:2464

Open

        $this->redirect($action, $mode, true, $query, $path);

• Exclude checks
  • Disable engine
  • Disable check

Property \e_admin_controller_ui->listQrySql has undeclared type \additional

Open

    protected $listQrySql = array();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_admin_controller_ui->_prefs (Did you mean expr->prefs or expr->_pref)

Open

        $this->_prefs = $config; // XXX Discuss.

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but ListDeleteTrigger() is declared to return null

Open

            return;            

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_db->mySQLlanguage

Open

            $lang = e107::getDb()->mySQLlanguage;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

            if(varset($val['tab']))

• Exclude checks
  • Disable engine
  • Disable check

Invalid offset "options" of array type array{}

Open

                    $opts = $this->fields['options'];

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_object::loadBatch

Open

        $this->getTreeModel()->setParam('db_query', $this->_modifyListQry(false, false, false, false, $this->listQry))->loadBatch();

• Exclude checks
  • Disable engine
  • Disable check

Default value for string $title can't be true

Open

    public function addTitle($title = true, $meta = true)

• Exclude checks
  • Disable engine
  • Disable check

Call with 2 arg(s) to \e_model::save() which only takes 0 arg(s) defined at /code/e107_handlers/model_class.php:1675

Open

                   $this->getModel()->setData($data)->save(false,true);

• Exclude checks
  • Disable engine
  • Disable check

Assigning null to property but \e_admin_ui->_model is \e_admin_model

Open

                $this->_model = null;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_object::loadBatch

Open

        $this->getTreeModel()->setParam('db_query', $this->_modifyListQry(false, false, false, false, $this->listQry))->loadBatch();

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 9 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'month9' => $tp->lanVars(LAN_UI_FILTER_PAST_XMONTHS,9),

• Exclude checks
  • Disable engine
  • Disable check

Default value for bool $glue can't be string

Open

    public function getHeaderContent($reset = true, $glue = "\n\n")

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \LAN_MANAGE

Open

        'main/edit' => LAN_MANAGE,

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (mode) is null but \e_admin_controller::redirect() takes string defined at /code/e107_handlers/admin_ui.php:2464

Open

        $this->redirect($action, null, $exclude_query, $merge_query);

• Exclude checks
  • Disable engine
  • Disable check

array to string conversion

Open

                e107::getMessage()->addDebug('Searching for custom batch method: ' .$method. '(' .$selected. ',' .$value. ')');

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (type) is 'delete' but \e_admin_ui::getEventTriggerName() takes null defined at /code/e107_handlers/admin_ui.php:4769

Open

                if($triggerName = $this->getEventTriggerName($this->getEventName(),'delete')) // trigger for before.

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"')) : '';

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                        $selectOpt .= $this->option($val, $key, false, array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"'));

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 3 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'nmonth3' => $tp->lanVars(LAN_UI_FILTER_NEXT_XMONTHS,3),

• Exclude checks
  • Disable engine
  • Disable check

Return type of _modifyListQrySearch() is undeclared type \Custom

Open

    public function _modifyListQrySearch($listQry, $searchTerm, $filterOptions, string $tablePath,  string $tableFrom, string $primaryName, $raw, $orderField, $qryAsc, $forceFrom, int $qryFrom, $forceTo, int $perPage, $qryField,  $isfilter, $handleAction)

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is int but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

            $caption = e107::getParser()->lanVars(LAN_UI_BATCH_BOOL_SUCCESS, $cnt, true);

• Exclude checks
  • Disable engine
  • Disable check

Call with 2 arg(s) to \e_model::save() which only takes 0 arg(s) defined at /code/e107_handlers/model_class.php:1675

Open

                        $check = $this->getModel()->setData($node->getData())->save(false, true);

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but handleListSearchfieldFilter() is declared to return string

Open

            return null;

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                            $selectOpt .= $this->option($v, $k, false, array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"'));

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (request_string) is ?array|?string but \e_admin_request::__construct() takes null|string defined at /code/e107_handlers/admin_ui.php:102

Open

            $request = new e_admin_request($request);

• Exclude checks
  • Disable engine
  • Disable check

Declaration of function getPrimaryName() : false should be compatible with function getPrimaryName() : string defined in /code/e107_handlers/admin_ui.php:3178

Open

    public function getPrimaryName()

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (fields) is true but \e_db::retrieve() takes string defined at /code/e107_handlers/e_db_interface.php:153

Open

                        $row = $sql->retrieve($query,true);

• Exclude checks
  • Disable engine
  • Disable check

Variable $res was undeclared, but array fields are being added to it.

Open

                 $res['caption'] = $data[$search];

• Exclude checks
  • Disable engine
  • Disable check

Assigning array{} to property but \e_admin_controller_ui->listQrySql is \additional

Open

    protected $listQrySql = array();

• Exclude checks
  • Disable engine
  • Disable check

Property \e_admin_controller_ui->filterQry has undeclared type \Custom

Open

    protected $filterQry;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (prefix) is true but \e_admin_controller_ui::getTableName() takes false|object defined at /code/e107_handlers/admin_ui.php:3332

Open

        $tableFrom  = '`'.$this->getTableName(false, true).'`'.($this->getTableName(true) ? ' AS '.$this->getTableName(true) : '');

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but GridBatchTrigger() is declared to return null

Open

            return; // always break on cancel!

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (_posted) is null but \e_admin_ui::triggerEvent() takes array defined at /code/e107_handlers/admin_ui.php:4707

Open

                        $this->triggerEvent($triggerName, null, $data, $id);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::hasLanguage

Open

        $val = e107::getDb()->hasLanguage($curTable, true);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 3 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'month3' => $tp->lanVars(LAN_UI_FILTER_PAST_XMONTHS,3),

• Exclude checks
  • Disable engine
  • Disable check

Assigning array{main/edit:mixed} to property but \e_admin_dispatcher->pageTitles is string

Open

    protected $pageTitles = array(

• Exclude checks
  • Disable engine
  • Disable check

Invalid operator: left operand of + is bool|resource (expected array or number)

Open

            $incVal = e107::getDb()->max($this->table, $this->sortField) + 1;

• Exclude checks
  • Disable engine
  • Disable check

Call with 2 arg(s) to \e_model::save() which only takes 0 arg(s) defined at /code/e107_handlers/model_class.php:1675

Open

                        $check = $this->getModel()->setData($node->getData())->save(false, true);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (number) is bool|string but \number_format() takes float|int

Open

                <div id='admin-ui-list-total-records' class='span6 col-md-6 right'><span>".e107::getParser()->lanVars(LAN_UI_TOTAL_RECORDS,number_format($this->getController()->getTreeModel()->getTotal())). '</span></div>

• Exclude checks
  • Disable engine
  • Disable check

Assigning string to property but \e_admin_request->_id is int

Open

            $this->_id = preg_replace('/[^\w\-:\.]/', '', $this->_request_qry[$this->_id_key]);

• Exclude checks
  • Disable engine
  • Disable check

Assigning false to property but \e_admin_controller_ui->formQuery is \e_admin_model

Open

    protected $formQuery = false; // custom form post query

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (replace) is int but \str_replace() takes array|string

Open

                $choice = explode('|', str_replace('{ID}', $id, $choice), 3);

• Exclude checks
  • Disable engine
  • Disable check

Expected @param annotation for qryField to be before the @param annotation for isfilter

Open

     * @param        $isfilter

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but ListBatchTrigger() is declared to return null

Open

            return; // always break on cancel!

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (type) is 'deleted' but \e_admin_ui::getEventTriggerName() takes null defined at /code/e107_handlers/admin_ui.php:4769

Open

                    if($triggerName = $this->getEventTriggerName($this->getEventName(), 'deleted')) // trigger for after.

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (total) is bool|string but \e_admin_form_ui::pagination() takes int defined at /code/e107_handlers/form_handler.php:2248

Open

        return $this->pagination(e_REQUEST_SELF.'?'.$paginate,$totalRecords,$fromPage,$perPage,array('template'=>'basic'));

• Exclude checks
  • Disable engine
  • Disable check

Assigning array{} to property but \e_admin_dispatcher->adminMenuAliases is string

Open

    protected $adminMenuAliases = array();

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                        if($attributes['data'] !== false)

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (className) is null but \e107::getAddonConfig() takes string defined at /code/e107_handlers/e107_class.php:2962

Open

        $tmp = e107::getAddonConfig('e_admin', null, 'config', $this);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is int but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

            $caption = e107::getParser()->lanVars(LAN_UI_BATCH_REVERSED_SUCCESS, $cnt, true);

• Exclude checks
  • Disable engine
  • Disable check

Call with 2 arg(s) to \e_model::save() which only takes 0 arg(s) defined at /code/e107_handlers/model_class.php:1675

Open

                        $check = $this->getModel()->setData($node->getData())->save(false, true);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (_posted) is null but \e_admin_ui::triggerEvent() takes array defined at /code/e107_handlers/admin_ui.php:4707

Open

                    if($halt = $this->triggerEvent($triggerName, null, $data, $id))

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                $var[$key]['link'] .= '&tab=' .$val['tab'];

• Exclude checks
  • Disable engine
  • Disable check

Default value for object $prefix can't be false

Open

    public function getTableName($alias = false, $prefix = false)

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_admin_controller_ui::handleCommaBatch

Open

                    $this->handleCommaBatch($selected, $field, $value, $trigger[0]);

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but doAfterSubmit() is declared to return null

Open

        return;

• Exclude checks
  • Disable engine
  • Disable check

Assigning null to property but \e_admin_ui->_model is \e_admin_model

Open

                    $this->_model = null;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::hasLanguage

Open

        if($curTable != e107::getDb()->hasLanguage($curTable))

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"')) : '';

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 6 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'month6' => $tp->lanVars(LAN_UI_FILTER_PAST_XMONTHS,6),

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 6 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'nmonth6' => $tp->lanVars(LAN_UI_FILTER_NEXT_XMONTHS,6),

• Exclude checks
  • Disable engine
  • Disable check

Property \e_admin_response->_title has undeclared type \unknown_type

Open

    protected $_title = array();

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but doAfterSubmit() is declared to return null

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Return type of _modifyListQry() is undeclared type \Custom

Open

    protected function _modifyListQry($raw = false, $isfilter = false, $forceFrom = false, $forceTo = false, $listQry = '')

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (className) is null but \e107::getAddonConfig() takes string defined at /code/e107_handlers/e107_class.php:2962

Open

            e107::getAddonConfig('e_admin',null,'process', $this, $id);

• Exclude checks
  • Disable engine
  • Disable check

Saw an @param annotation for var, but it was not found in the param list of function _isSearchField($field, string $searchQuery) : bool

Open

     * @param array $var

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 0 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

        $caption = e107::getParser()->lanVars(LAN_UI_BATCH_BOOL_SUCCESS, $c, true);

• Exclude checks
  • Disable engine
  • Disable check

When appending to a value of type array{}, found an array access index of type null, but expected the index to be of type int|string

Open

        $forms[$id] = array(

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"')) : '';

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

            if(isset($val['perm']) && $val['perm']!=='' && !getperms($val['perm']))

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_admin_controller_ui::handleCommaBatch

Open

                    $this->handleCommaBatch($selected, $field, array_keys($classes), $trigger[0] === 'ucdelall' ? 'clearAll' : 'addAll');

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (tree_models) is array<string>|array<string>|array<string>|array<string>|array<string>|array<string>|array<string>|array{}</string></string></string></string></string></string></string> but \e_admin_form_ui::renderListForm() takes \e_admin_tree_model defined at /code/e107_handlers/form_handler.php:7380

Open

        return $this->renderListForm($options, $tree, $ajax);

• Exclude checks
  • Disable engine
  • Disable check

Assigning array{} to property but \e_admin_response->_title is \unknown_type

Open

    protected $_title = array();

• Exclude checks
  • Disable engine
  • Disable check

Default value for bool $return can't be string

Open

    public function run($run_header = true, $return = 'render')

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_admin_controller_ui::handleCommaBatch

Open

                    $this->handleCommaBatch($selected, $field, $class, $trigger[0]);

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_object::loadBatch

Open

            $this->getTreeModel()->setParam('db_query', $this->_modifyListQry(false, false, false, false, $this->listQry))->loadBatch(true);

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but ListDeleteTrigger() is declared to return null

Open

            return; // always break on cancel!

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but ListDeleteTrigger() is declared to return null

Open

            return; // User confirmation expected

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (pid) is false but \e_admin_form_ui::setAdminAddonModel() takes string defined at /code/e107_handlers/admin_ui.php:7482

Open

        $this->setAdminAddonModel($tree[$id], array_keys($fields), $pid);

• Exclude checks
  • Disable engine
  • Disable check

Method \e_admin_ui::renderHelp is declared to return string but has no return value

Open

    public function renderHelp()

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"')) : '';

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{class:'ui-batch-option class',other:'style="padding-left: 15px"'} but \e_admin_form_ui::option() takes string defined at /code/e107_handlers/form_handler.php:3590

Open

                array('class' => 'ui-batch-option class', 'other' => 'style="padding-left: 15px"')) : '';

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is 9 but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

                                'nmonth9' => $tp->lanVars(LAN_UI_FILTER_NEXT_XMONTHS,9),

• Exclude checks
  • Disable engine
  • Disable check

Returning type void but doAfterSubmit() is declared to return null

Open

            return;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (value) is ?'\'\''|?string but \e_admin_tree_model::batchUpdate() takes string defined at /code/e107_handlers/model_class.php:4016

Open

        $cnt = $this->getTreeModel()->batchUpdate($field, $val, $selected, true, false);

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but SortAjaxPage() is declared to return void

Open

            return null;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_object::loadBatch

Open

        $this->getTreeModel()->setParam('db_query', $this->_modifyListQry(false, false, 0, false, $this->listQry))->loadBatch();

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vals) is int but \e_parse::lanVars() takes array|string defined at /code/e107_handlers/e_parse_class.php:3842

Open

            $legend = e107::getParser()->lanVars(LAN_UI_EDIT_LABEL, $controller->getId()); // sprintXXX(LAN_UI_EDIT_LABEL, $controller->getId());

• Exclude checks
  • Disable engine
  • Disable check