e107inc/e107

File application.php has 2980 lines of code (exceeds 2000 allowed). Consider refactoring.

Open

<?php
/*
 * e107 website system
 *
 * Copyright (C) 2008-2012 e107 Inc (e107.org)

Avoid deeply nested control flow statements.

Open

                            if($rule->allowVars)
                            {
                                foreach ($rule->allowVars as $key) 
                                {
                                    if(isset($_GET[$key]) && !$request->isRequestParam($key))

Avoid too many return statements within this method.

Open

                return $base.$route.$urlSuffix.'?'.$params.$anc;

Avoid too many return statements within this method.

Open

            return $base.$route.$urlSuffix.'?'.$params.$anc;

Avoid too many return statements within this method.

Open

        return rtrim($url, '/');

Avoid too many return statements within this method.

Open

                return self::underscore($title);

Avoid too many return statements within this method.

Open

        return $format === self::FORMAT_GET ? $base.'?'.$this->routeVar.'='.$route.$anc : $base.$route.$urlSuffix.$anc;

Avoid too many return statements within this method.

Open

                return $base.$tmp.$anc;

Avoid too many return statements within this method.

Open

             return $url !== '' ? $url.$suffix : $url;

Avoid too many return statements within this method.

Open

                return null;

Avoid too many return statements within this method.

Open

            return $base.$route.$urlSuffix.$anc;

Avoid too many return statements within this method.

Open

        return null;

Avoid too many return statements within this method.

Open

                     return $base.rtrim(($this->isMainModule($module) ? '' : $alias.'/').$url, '/').$anc;

Avoid too many return statements within this method.

Open

                return str_replace(' ', '+', self::camelize($title, true, ' '));

Avoid too many return statements within this method.

Open

                return str_replace(' ', '+', $tp->ustrtolower($title));

Avoid too many return statements within this method.

Open

                return $title;

Avoid too many return statements within this method.

Open

                return str_replace(' ', '+', $title);

Invalid offset "en" of array type array{}

Open

        $arr = (!empty($this->_legacyAliases[e_LAN])) ?  array_merge($this->_legacy,$this->_legacyAliases[e_LAN]) : $this->_legacy;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (args) is null but \array_merge() takes array

Open

        $arr = (!empty($this->_legacyAliases[e_LAN])) ?  array_merge($this->_legacy,$this->_legacyAliases[e_LAN]) : $this->_legacy;

• Exclude checks
  • Disable engine
  • Disable check

Returning type string but isLegacy() is declared to return bool

Open

        return self::$_legacy;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getController() is declared to return \eController

Open

        if(!$class_name) return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but retrieveModule() is declared to return string

Open

            return null;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (options) is '/' but \eRouter::createPathInfo() takes array defined at /code/e107_handlers/application.php:2406

Open

        if ($this->append) $url .= '/'.$manager->createPathInfo($params, '/', '/').$suffix;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (params) is '' but \eRouter::assemble() takes array defined at /code/e107_handlers/application.php:2133

Open

            $url = eFront::instance()->getRouter()->assemble($url, '', 'encode=0');

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (mode) is 'mix' but \e_parse::createConstants() takes int defined at /code/e107_handlers/e_parse_class.php:3255

Open

        return e107::getParser()->createConstants($url, 'mix');

• Exclude checks
  • Disable engine
  • Disable check

Assigning \e_vars to property but \eUrlRule->_regexTemplates is \e_var

Open

        $this->_regexTemplates = new e_vars($this->regexTemplates);

• Exclude checks
  • Disable engine
  • Disable check

Returning type array but getValidator() is declared to return \e_validator

Open

        return $this->_validator;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                       $("#'.$metaTitleID.'").addClass("has-error");

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (options) is 'encode=0&full=1' but \eRouter::assemble() takes array defined at /code/e107_handlers/application.php:2133

Open

                    $redirect = $this->assemble($this->notFoundUrl, '', 'encode=0&full=1');

• Exclude checks
  • Disable engine
  • Disable check

Assigning \e_validator to property but \eControllerFront->_validator is array

Open

            $this->_validator = new e_validator('controller');

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getRouteHistory() is declared to return array|string

Open

        if(!$this->_routeHistory) return null;

• Exclude checks
  • Disable engine
  • Disable check

Parameter $metaTitleID has undeclared type \str

Open

    public static function syncSEOTitle($titleID, $metaTitleID)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    var charlimit = $("#'.$metaTitleID.'").attr("data-char-count");

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                $("#'.$metaTitleID.'").attr("placeholder",title);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (location) is null but \eRouter::file2config() takes string defined at /code/e107_handlers/application.php:1271

Open

                $c = eRouter::file2config($file, $location);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (status) is array but \eFront::isLegacy() takes bool defined at /code/e107_handlers/application.php:554

Open

            eFront::isLegacy($this->getConfigValue($module, 'legacy'));

• Exclude checks
  • Disable engine
  • Disable check

Variable $tr2 was undeclared, but array fields are being added to it.

Open

        $tr2['/'] = $tr['/'] = '\\/';

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (pathInfo) is \eRequest but \eRouter::parsePathInfo() takes string defined at /code/e107_handlers/application.php:2448

Open

                $manager->parsePathInfo($request, ltrim(substr($pathInfo, strlen($matches[0])), '/'));

• Exclude checks
  • Disable engine
  • Disable check

false to array comparison

Open

        if(false !== $params) $request->setRequestParams($params);

• Exclude checks
  • Disable engine
  • Disable check

Assigning null to property but \eRequest->_controller is string

Open

            $this->_controller = null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getConfigObject() is declared to return \eUrlConfig

Open

            if(!$location) return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getAliasFromModule() is declared to return string

Open

            return (in_array($module, $aliases) ? array_search($module, $aliases) : null);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (vars) is \e_var but \e_parse::simpleParse() takes \e_vars|array defined at /code/e107_handlers/e_parse_class.php:886

Open

                    $value = $tp->simpleParse($value, $this->_regexTemplates, '[^\/]+');

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getRouteHistory() is declared to return array|string

Open

        return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getDispatchLocationPath() is declared to return string

Open

                if(!$plugin) return null;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (route) is null but \eRequest::setRoute() takes string defined at /code/e107_handlers/application.php:3834

Open

            $request->setRequestInfo($url)->setPathInfo(null)->setRoute(null);

• Exclude checks
  • Disable engine
  • Disable check

Assigning \e_vars to property but \eUrlRule->_regexTemplates is \e_var

Open

                $this->_regexTemplates = new e_vars($this->regexTemplates);

• Exclude checks
  • Disable engine
  • Disable check

Variable $tr was undeclared, but array fields are being added to it.

Open

        $tr2['/'] = $tr['/'] = '\\/';

• Exclude checks
  • Disable engine
  • Disable check

Assigning array<string></string> to property but \eResponse->_title is array<string>&gt;|array<string>|array<string>|array{default:array{}}</string></string></string>

Open

                $this->_title['default'] = '';

• Exclude checks
  • Disable engine
  • Disable check

Invalid offset "format" of array type array{configClass:string}|array{configPath:string}|array{location:mixed}|array{}

Open

            if(!isset($_config['config']['format']) || !in_array($_config['config']['format'], array(self::FORMAT_GET, self::FORMAT_PATH)))

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (route) is ?string but \eRequest::initFromRoute() takes string defined at /code/e107_handlers/application.php:3902

Open

        return $this->initFromRoute($route);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    var title = $("#'.$titleID.'").val() + " | " + "'.SITENAME.'";

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

            $("#'.$metaTitleID.'").on("ready focus", function() {

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

            $("#'.$titleID.'").on("input change focus", function() 

• Exclude checks
  • Disable engine
  • Disable check

Variable $file is undeclared

Open

                            define('e_PAGE', basename($file));

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getConfigObject() is declared to return \eUrlConfig

Open

            if(!is_readable($path)) return null;

• Exclude checks
  • Disable engine
  • Disable check

Property \eUrlRule->_regexTemplates has undeclared type \e_var (Did you mean class \e_vars)

Open

    protected $_regexTemplates;

• Exclude checks
  • Disable engine
  • Disable check

Method \eUrlConfig::create is declared to return array|string but has no return value

Open

    public function create($route, $params = array(), $options = array()) {}

• Exclude checks
  • Disable engine
  • Disable check

Assigning null to property but \eRequest->_action is string

Open

            $this->_action = null;

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

                    elseif(getperms('0'))

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type object of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

            throw new eException("Controller $controller is not an instance of eController");

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getControllerClass() is declared to return string

Open

        return ($location ? $location.'_'.$module.'_'.$controllerName.'_controller' : null);

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but isDispatchableModule() is declared to return string

Open

            if(!$class_name) return false;

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param array current configuration array (url_config core preference like)': after array, did not see an element name (will guess based on comment order)

Open

     * @param array current configuration array (url_config core preference like)

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (pathInfo) is null but \eRequest::setPathInfo() takes string defined at /code/e107_handlers/application.php:3660

Open

            $request->setRequestInfo($url)->setPathInfo(null)->setRoute(null);

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but parse() is declared to return string

Open

        return false;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                var title = $("#'.$titleID.'").val() + " | " + "'.SITENAME.'";

• Exclude checks
  • Disable engine
  • Disable check

Invalid offset "en" of array type array{}

Open

                    $alias = (!empty($this->_alias[e_LAN][$plug][$k])) ? $this->_alias[e_LAN][$plug][$k] : $v['alias'];

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to true

Open

            if(!empty($status[0]) && ($status[0] === '{'))

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getConfigLocationPath() is declared to return string

Open

                return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but isDispatchableModule() is declared to return string

Open

            if(($location = eDispatcher::getModuleRealLocation($module)) === null) return false;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getAliasFromModule() is declared to return string

Open

        return (in_array($module, $this->_aliases) ? array_search($module, $this->_aliases) : null);

• Exclude checks
  • Disable engine
  • Disable check

Assigning null to property but \eRequest->_module is string

Open

            $this->_module = null;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                var title = $("#'.$titleID.'").val() + " | " + "'.SITENAME.'";

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (text) is true but \e_parse::replaceConstants() takes string defined at /code/e107_handlers/e_parse_class.php:3025

Open

                $status = e107::getParser()->replaceConstants($status);

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getControllerPath() is declared to return string

Open

        return ($location ? self::getDispatchPath($module, $location, $sc).$controller.'.php': null);

• Exclude checks
  • Disable engine
  • Disable check

array to false comparison

Open

        if($this->allowVars === false) $this->allowVars = array_keys($this->params);

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param array available URL modules as detected by {@link eDispatcher::adminReadModules()} and stored as url_modules core preference value': after array, did not see an element name (will guess based on comment order)

Open

     * @param array available URL modules as detected by {@link eDispatcher::adminReadModules()} and stored as url_modules core preference value

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param string module': after string, did not see an element name (will guess based on comment order)

Open

     * @param string module

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \e_UC_PUBLIC

Open

    protected $userclass = e_UC_PUBLIC;

• Exclude checks
  • Disable engine
  • Disable check

Parameter $titleID has undeclared type \str

Open

    public static function syncSEOTitle($titleID, $metaTitleID)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                    $("#'.$metaTitleID.'").attr("placeholder",title);

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getModuleFromAlias() is declared to return string

Open

        return (isset($this->_aliases[$alias]) ? $this->_aliases[$alias] : null);

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param void': after void, did not see an element name (will guess based on comment order)

Open

     * @param void

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \str of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

                if(!$("#'.$metaTitleID.'").val()) 

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (params) is '' but \eRouter::assemble() takes array defined at /code/e107_handlers/application.php:2133

Open

                    $redirect = $this->assemble($this->notFoundUrl, '', 'encode=0&full=1');

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (options) is 'encode=0' but \eRouter::assemble() takes array defined at /code/e107_handlers/application.php:2133

Open

            $url = eFront::instance()->getRouter()->assemble($url, '', 'encode=0');

• Exclude checks
  • Disable engine
  • Disable check

When appending to a value of type array{}, found an array access index of type ?string, but expected the index to be of type int|string

Open

                $this->_meta[$name] = $attr;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getConfigPath() is declared to return string

Open

                return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getDispatchLocationPath() is declared to return string

Open

                return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but isDispatchableModule() is declared to return string

Open

        return false;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getConfigObject() is declared to return \eUrlConfig

Open

            if(!class_exists($className, false)) return null;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (status) is '' but \eFront::isLegacy() takes bool defined at /code/e107_handlers/application.php:554

Open

                eFront::isLegacy(''); // reset legacy - not found route isn't legacy call

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getRouteHistory() is declared to return array|string

Open

            return isset($this->_routeHistory[$source]) ? $this->_routeHistory[$source] : null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but getDispatchPath() is declared to return string

Open

                return null;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (encoded_string) is array but \parse_str() takes string

Open

                parse_str($this->defaultParams, $this->defaultParams);

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (action) is null but \e_jshelper::sendJsonResponse() takes string defined at /code/e107_handlers/js_helper.php:222

Open

        $jshelper->sendJsonResponse(null);

• Exclude checks
  • Disable engine
  • Disable check