e107inc/e107

Method form_comment has 9 arguments (exceeds 7 allowed). Consider refactoring.

Open

    function form_comment($action, $table, $id, $subject, $content_type, $return = FALSE, $rating = FALSE, $tablerender = TRUE,$pid = false)

Avoid deeply nested control flow statements.

Open

                                    if ($sql2->select($var['db_table'], $var['db_title'], $var['db_id']." = '".$row['comment_item_id']."' "))
                                    {
                                        $row2 = $sql2->fetch();
                                        $ret['comment_type'] = $var['plugin_name'];
                                        $ret['comment_title'] = $tp->toHTML($row2[$var['db_title']], TRUE, 'emotes_off, no_make_clickable');

Avoid deeply nested control flow statements.

Open

                                    if ($installed = isset($pref['plug_installed'][$var['plugin_path']]))
                                    {
                                        $qryp = str_replace("{NID}", $row['comment_item_id'], $var['qry']);
                                        if ($sql2->gen($qryp))
                                        {

Method compose_comment has 8 arguments (exceeds 7 allowed). Consider refactoring.

Open

    function compose_comment($table, $action, $id, $width, $subject, $rate = FALSE, $return = FALSE, $tablerender = TRUE)

Avoid too many return statements within this method.

Open

                            return "Error";    

Avoid too many return statements within this method.

Open

        return false;

Avoid too many return statements within this method.

Open

                return emessage;    

Avoid too many return statements within this method.

Open

        return 'ro';

Avoid too many return statements within this method.

Open

            return $ns->tablerender("<span id='e-comment-total'>".$this->totalComments."</span> ".LAN_COMMENTS, $TEMPL, 'comment', true);

Avoid too many return statements within this method.

Open

                        return false; //3rd party code interception

Avoid too many return statements within this method.

Open

        return (!$return) ? "" : $ret;

Avoid too many return statements within this method.

Open

                        return $inserted_id; // return the ID number so it can be used. true;

Returning type null but form_comment() is declared to return string

Open

            return null;

• Exclude checks
  • Disable engine
  • Disable check

Default value for \unknown_type $pid can't be string

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Default value for \unknown_type $table can't be string

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $pid has undeclared type \unknown_type

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $subject has undeclared type \unknown_type

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $rateindex has undeclared type \unknown_type

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $id has undeclared type \unknown_type

Open

    function count_comments($table, $id)

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

        if(!getperms('0') && !getperms("B"))

• Exclude checks
  • Disable engine
  • Disable check

Parameter $comment has undeclared type \unknown_type

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Returning type ?string but form_comment() is declared to return string

Open

            return $text;

• Exclude checks
  • Disable engine
  • Disable check

Default value for \unknown_type $rateindex can't be false

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (table) is \unknown_type but \comment::getCommentType() takes string defined at /code/e107_handlers/comment_class.php:914

Open

        $type = $this->getCommentType($table);

• Exclude checks
  • Disable engine
  • Disable check

Default value for int $addrating can't be false

Open

    function render_comment($row, $table, $action, $id, $width=0, $subject='', $addrating = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Parameter $table has undeclared type \unknown_type

Open

    function count_comments($table, $id)

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (caption) is null but \e_render::tablerender() takes string defined at /code/e107_handlers/e_render_class.php:314

Open

                    echo $ns->tablerender(null, $text, 'comment', true);

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (default) is 'e107' but \e107::pref() takes null defined at /code/e107_handlers/e107_class.php:4016

Open

        $this->engine = e107::pref('core', 'comments_engine', 'e107');

• Exclude checks
  • Disable engine
  • Disable check

Default value for int $id can't be string

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param array - a row from the comments table.': after array, did not see an element name (will guess based on comment order)

Open

     * @param array - a row from the comments table. 

• Exclude checks
  • Disable engine
  • Disable check

Default value for \unknown_type $comment can't be string

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (text) is array|bool but \e_render::tablerender() takes string defined at /code/e107_handlers/e_render_class.php:314

Open

                    echo $ns->tablerender(null, $text, 'comment', true);

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

        if(!getperms('0') && !getperms("B"))

• Exclude checks
  • Disable engine
  • Disable check

Parameter $table has undeclared type \unknown_type

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

        if(getperms('B')) // moderator perms. 

• Exclude checks
  • Disable engine
  • Disable check

Default value for \unknown_type $subject can't be string

Open

    function enter_comment($data, $comment='', $table='', $id='', $pid='', $subject='', $rateindex = FALSE)

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (fields) is true but \e_db::retrieve() takes string defined at /code/e107_handlers/e_db_interface.php:153

Open

        if ($rows = $sql->retrieve($query,true))

• Exclude checks
  • Disable engine
  • Disable check

Variable $plugin_name is undeclared

Open

                            $e_comment['plugin_name'] = $plugin_name;

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \getperms() defined at /code/class2.php:1322

Open

            if($this->totalComments && getperms("B"))

• Exclude checks
  • Disable engine
  • Disable check

Variable $db_table is undeclared

Open

                            $e_comment['db_table'] = $db_table;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious argument null for an echo/print statement

Open

                    echo $ns->tablerender("<span id='e-comment-total'>".$this->totalComments."</span> ".LAN_COMMENTS, $TEMPL, 'comment', TRUE);

• Exclude checks
  • Disable engine
  • Disable check

Variable $key is undeclared

Open

                    unset($e_comment, $key);

• Exclude checks
  • Disable engine
  • Disable check

Variable $plugin_path is undeclared

Open

                            $e_comment['plugin_path'] = $plugin_path;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                        $ret['comment_title'] = $tp->toHTML($row2[$var['db_title']], TRUE, 'emotes_off, no_make_clickable');

• Exclude checks
  • Disable engine
  • Disable check

Variable $ret was undeclared, but array fields are being added to it.

Open

                $ret['comment'] = $text;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                        $ret['comment_type'] = $var['plugin_name'];

• Exclude checks
  • Disable engine
  • Disable check

Parameter $type has undeclared type \str

Open

    public function getNested($pid, $type)

• Exclude checks
  • Disable engine
  • Disable check

Variable $e_comment is undeclared

Open

                    unset($e_comment, $key);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (text) is array|bool but \e_render::tablerender() takes string defined at /code/e107_handlers/e_render_class.php:314

Open

                return $ns->tablerender(null, $text, 'comment', true);

• Exclude checks
  • Disable engine
  • Disable check

Variable $reply_location is undeclared

Open

                            $e_comment['reply_location'] = $reply_location;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                        $ret['comment_url'] = str_replace("{NID}", $row['comment_item_id'], $var['reply_location']);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                        $ret['comment_category_url'] = e_PLUGIN_ABS.$var['plugin_name'].'/'.$var['plugin_name'].'.php';

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to false

Open

                            $data[$key] = $e_comment;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious argument array|bool for an echo/print statement

Open

                    echo $text;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to false

Open

                            $data[$key] = $e_comment;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                    if ($sql2->select($var['db_table'], $var['db_title'], $var['db_id']." = '".$row['comment_item_id']."' "))

• Exclude checks
  • Disable engine
  • Disable check

Suspicious argument null for an echo/print statement

Open

                    echo $ns->tablerender(null, $text, 'comment', true);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to ?mixed

Open

                                        $ret['comment_category_heading'] = $var['plugin_name'];

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (fields) is true but \e_db::retrieve() takes string defined at /code/e107_handlers/e_db_interface.php:153

Open

        if($nested = e107::getDb()->retrieve($query, true))

• Exclude checks
  • Disable engine
  • Disable check

Variable $db_id is undeclared

Open

                            $e_comment['db_id'] = $db_id;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (caption) is null but \e_render::tablerender() takes string defined at /code/e107_handlers/e_render_class.php:314

Open

                return $ns->tablerender(null, $text, 'comment', true);

• Exclude checks
  • Disable engine
  • Disable check

Variable $link_name is undeclared

Open

                            $e_comment['db_title'] = $link_name;

• Exclude checks
  • Disable engine
  • Disable check