e107inc/e107

Avoid deeply nested control flow statements.

Open

                                    if(E107_DBG_SQLDETAILS)
                                    {
                                        $mes = e107::getMessage();
                                        $mes->add("db_table_admin_class.php :: parse_field_defs() Line: 230 - Unknown definition {$i}: ".$fd[$i], E_MESSAGE_DEBUG);
                                    }

Avoid deeply nested control flow statements.

Open

                                    if (isset($fd[$i + 1]))
                                    {
                                        $i++;
                                        $defs['default'] = $fd[$i];
                                    }

Avoid too many return statements within this method.

Open

                return TRUE; // Success even if no changes required

Avoid too many return statements within this method.

Open

            return "Cannot generate definition for: ".$list['type'].' '.$list['name'];

Avoid too many return statements within this method.

Open

                        return $sql->dbError(__METHOD__);

Avoid too many return statements within this method.

Open

            return array(
                $error_list, $change_list
            );

Variable $defs was undeclared, but array fields are being added to it.

Open

                            $defs['type'] = 'pkey';

• Exclude checks
  • Disable engine
  • Disable check

Variable $defs was undeclared, but array fields are being added to it.

Open

                        $defs['type'] = 'field';

• Exclude checks
  • Disable engine
  • Disable check

Variable $defs was undeclared, but array fields are being added to it.

Open

                            $defs['type'] = 'ftkey';

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (var) is ?array|?array{autoinc:true}|?array{default:string}|?array{fieldtype:string}|?array{keyfield:string}|?array{name:string}|?array{nulltype:'NOT NULL'}|?array{type:'field'}|?array{type:'ftkey'}|?array{type:'key'}|?array{type:'pkey'}|?array{type:'ukey'}|?array{vartype:string} but \count() takes \Countable|array

Open

                    if (count($defs) > 1)

• Exclude checks
  • Disable engine
  • Disable check

Variable $defs was undeclared, but array fields are being added to it.

Open

                        $defs['type'] = 'key';

• Exclude checks
  • Disable engine
  • Disable check

Variable $defs was undeclared, but array fields are being added to it.

Open

                            $defs['type'] = 'ukey';

• Exclude checks
  • Disable engine
  • Disable check