e107inc/e107

Consider simplifying this complex logical expression.

Open

          if(($this->curLayout == 'legacyCustom' || $this->curLayout=='legacyDefault') && (isset($CUSTOMHEADER) || isset($CUSTOMFOOTER)) )  // 0.6 themes.
        {
             if($this->curLayout == 'legacyCustom')
            {
                $HEADER = ($CUSTOMHEADER) ? $CUSTOMHEADER : $HEADER;

Avoid too many return statements within this method.

Open

            return;

Avoid too many return statements within this method.

Open

        if(!$this->dragDrop){ return; }

Variable $order was undeclared, but array fields are being added to it.

Open

            $order[] = $id;

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (checked) is '' but \e_form::checkbox() takes bool|false defined at /code/e107_handlers/form_handler.php:2685

Open

            $tab1 .= "<li>" . $frm->checkbox('menuselect[]', $row['menu_id'], '', array('label' => "<span>" . $row['menu_name'] . "<small>" . $menuInf . "</small></span>")) . "</li>";

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->style (Did you mean $style)

Open

        $style = $this->style;

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param incrementor number.': after incrementor, did not see an element name (will guess based on comment order)

Open

     * @param incrementor number.

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][name]',$row['name'],array('id'=>'name-'.$area.'-'.$c) );

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][pages]',$row['pages'], array('id'=>'pages-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $visibilityLink = e_SELF."?enc=".base64_encode('lay='.$layout.'&vis='.$area.'-'.$c.'&iframe=1&class='.$row['class'].'&pages='.$row['pages']);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->HEADER

Open

        if(is_string($this->HEADER))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMFOOTER

Open

                    foreach($this->CUSTOMFOOTER as $k=>$v)

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to nullable ?array

Open

                if(vartrue($_POST['menuSetCustomPages']))

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to nullable ?array

Open

                    $custompages = $tp->filter($_POST['custompages']);

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type array<int>&gt;&gt;|array<int>&gt;|array{},</int></int> found an array index of type string, but expected the index to be of type int

Open

                        $rows = $this->menuData[$menu];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->curLayout

Open

            $this->curLayout = vartrue($_GET['configure'], $pref['sitetheme_deflayout']);

• Exclude checks
  • Disable engine
  • Disable check

string passed to foreach instead of array

Open

        foreach($_POST['data']['layout']['area'] as $v) // reset key values.

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $visibilityLink = e_SELF."?enc=".base64_encode('lay='.$layout.'&vis='.$area.'-'.$c.'&iframe=1&class='.$row['class'].'&pages='.$row['pages']);

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{label:string,class:'e-save'} but \e_form::radio() takes null defined at /code/e107_handlers/form_handler.php:2942

Open

        $text .= $frm->radio('listtype', 2, $checked, array('label'=> $tp->toHTML(MENLAN_27,true), 'class'=> 'e-save'));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_menuManager->customMenu

Open

            if(isset($this->customMenu))

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (checked) is '' but \e_form::checkbox() takes bool|false defined at /code/e107_handlers/form_handler.php:2685

Open

            $tab2 .= "<li>" . $frm->checkbox('menuselect[]', $row['menu_id'], '', array('label' => "<span>" . $row['menu_name'] . "<small>" . $menuInf . "</small></span>")) . "</li>";

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->FOOTER (Did you mean $FOOTER)

Open

            $this->FOOTER         = $FOOTER;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][parms]',$row['parms'], array('id'=>'parms-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (checked) is '' but \e_form::checkbox() takes bool|false defined at /code/e107_handlers/form_handler.php:2685

Open

                $text .= $frm->checkbox('menuselect[]',$row['menu_id'],'',array('label'=>$row['menu_name'].$menuInf));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_menuManager->customMenu

Open

            if(isset($this->customMenu) && count($this->customMenu))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER (Did you mean $CUSTOMHEADER)

Open

            $this->CUSTOMHEADER = $CUSTOMHEADER;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER (Did you mean $CUSTOMHEADER)

Open

            $this->CUSTOMHEADER = varset($CUSTOMHEADER);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to nullable ?array<string>|?mixed</string>

Open

                            $menuText .= "\n\n\n <!-- Menu Start ".$row['menu_name']. "-->\n";

• Exclude checks
  • Disable engine
  • Disable check

Assigning string to property but \e_menuManager->menuId is int

Open

                $this->menuId = $deleteID;

• Exclude checks
  • Disable engine
  • Disable check

Variable $tmp was undeclared, but array fields are being added to it.

Open

                     $tmp[$id]['name'] = ucwords(str_replace($search,"",$row['menu_name'])); // remove _

• Exclude checks
  • Disable engine
  • Disable check

Parameter $area has undeclared type \number

Open

    public function renderMenuOptions($row, $layout, $area, $c , $uniqueId='xxx')

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{label:string,class:'e-save'} but \e_form::radio() takes null defined at /code/e107_handlers/form_handler.php:2942

Open

        $text .= $frm->radio('listtype', 1, $checked, array('label'=> $tp->toHTML(MENLAN_26,true), 'class'=> 'e-save'));

• Exclude checks
  • Disable engine
  • Disable check

Variable $menuArea was undeclared, but array fields are being added to it.

Open

                $menuArea[] = array(

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::escape

Open

            $parms = $sql->escape(strip_tags($parms));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->style (Did you mean $style)

Open

            $this->style        = $style;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->FOOTER (Did you mean $FOOTER)

Open

            $this->FOOTER         = varset($FOOTER);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][path]',$row['path'], array('id'=>'path-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][pages]',$row['pages'], array('id'=>'pages-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= "<a href='#'  class='menuOption menu-btn menu-btn-mini menu-btn-danger deleteMenu pull-right' data-area='area-".$area."' data-delete='".$uniqueId."'>&times;</a>"; // $('.hello').remove();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->HEADER

Open

            $H['default'] = $this->HEADER;

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (where) is null but \e_db::retrieve() takes string defined at /code/e107_handlers/e_db_interface.php:153

Open

        if($result = $sql->retrieve('menus', 'menu_name', null, true))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_menuManager->customMenu

Open

                $this->customMenu[] = $cust;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->HEADER (Did you mean $HEADER)

Open

            $this->HEADER         = $HEADER;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMFOOTER (Did you mean $CUSTOMFOOTER)

Open

            $this->CUSTOMFOOTER = $CUSTOMFOOTER;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][class]',$row['class'], array('id'=>'class-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER

Open

             if(!is_array($this->CUSTOMHEADER))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->HEADER (Did you mean $HEADER)

Open

            $this->HEADER         = varset($HEADER);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER

Open

                    $H['legacyCustom'] = $this->CUSTOMHEADER;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMFOOTER

Open

                    $F['legacyCustom'] = $this->CUSTOMFOOTER;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_menuManager->customMenu

Open

                $text .= "<p>".MENLAN_52."<ul ><li>".implode("</li><li>",$this->customMenu)."</li></ul></p>";    

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMFOOTER (Did you mean $CUSTOMFOOTER)

Open

            $this->CUSTOMFOOTER = varset($CUSTOMFOOTER);

• Exclude checks
  • Disable engine
  • Disable check

Variable $row is undeclared

Open

            <legend>". MENLAN_7." ".$row['menu_name']."</legend>

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{label:string,class:'e-save'} but \e_form::radio() takes null defined at /code/e107_handlers/form_handler.php:2942

Open

        $text .= $frm->radio('listtype', 2, $checked, array('label'=>  $tp->toHTML(MENLAN_27,true), 'class'=> 'e-save'));

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER

Open

        if(!empty($this->CUSTOMHEADER))

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (c) is int but \e_mm_layout::renderMenuOptions() takes \incrementor defined at /code/e107_handlers/menumanager_class.php:2785

Open

        return '<li class="regularMenu" id="'.$uniqueId.'"> '.$this->renderMenuOptions($row, $layout, $area, $this->cnt, $uniqueId)." </li>\n";

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][class]',$row['class'], array('id'=>'class-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][parms]',$row['parms'], array('id'=>'parms-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->curLayout

Open

            <form class='form-horizontal' id='e-save-form' method='post' action='".e_SELF."?lay=".$this->curLayout."&amp;iframe=1'>

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->FOOTER

Open

            $F = $this->FOOTER;

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (noWhere) is 'default' but \e_db::select() takes bool|false defined at /code/e107_handlers/e_db_interface.php:265

Open

            if($sql->select('menus', 'menu_name', 'menu_id='.$this->menuId, 'default'))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->curLayout

Open

            $this->renderLayout($this->curLayout);

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type string, found an array index of type 'area', but expected the index to be of type int

Open

        foreach($_POST['data']['layout']['area'] as $v) // reset key values.

• Exclude checks
  • Disable engine
  • Disable check

Parameter $c has undeclared type \incrementor

Open

    public function renderMenuOptions($row, $layout, $area, $c , $uniqueId='xxx')

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->FOOTER

Open

            $F['default'] = $this->FOOTER;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->HEADER

Open

            $H = $this->HEADER;

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (fields) is true but \e_db::retrieve() takes string defined at /code/e107_handlers/e_db_interface.php:153

Open

        if($rows = $sql->retrieve($menu_qry, true))

• Exclude checks
  • Disable engine
  • Disable check

Variable $menu_perm was undeclared, but array fields are being added to it.

Open

           $menu_perm['everyone'] = e_UC_PUBLIC;

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \number of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][name]',$row['name'],array('id'=>'name-'.$area.'-'.$c) );

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{label:string,class:'e-save'} but \e_form::radio() takes null defined at /code/e107_handlers/form_handler.php:2942

Open

        $text .= $frm->radio('listtype', 1, $checked, array('label'=>$tp->toHTML(MENLAN_26,true), 'class'=> 'e-save'));

• Exclude checks
  • Disable engine
  • Disable check

Call to deprecated function \save_prefs() defined at /code/class2.php:1401

Open

        save_prefs();

• Exclude checks
  • Disable engine
  • Disable check

Variable $text is undeclared

Open

                        unset($text);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious array access to nullable ?array<string>|?mixed</string>

Open

                            $menuText .= "<div class='{$cl}' id='block-".$row['menu_id']."-".$menu."'>\n";

• Exclude checks
  • Disable engine
  • Disable check

Variable $insert was undeclared, but array fields are being added to it.

Open

        $insert[] = $insertID;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->style (Did you mean $style)

Open

            $this->style        = varset($style);

• Exclude checks
  • Disable engine
  • Disable check

Suspicious type \incrementor of a variable or expression used to build a string. (Expected type to be able to cast to a string)

Open

        $text .= $frm->hidden('data[layout][area]['.$c.'][path]',$row['path'], array('id'=>'path-'.$area.'-'.$c)  );

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared property \e_mm_layout->CUSTOMHEADER

Open

                    foreach($this->CUSTOMHEADER as $k=>$v)

• Exclude checks
  • Disable engine
  • Disable check