e107inc/e107

Avoid deeply nested control flow statements.

Open

                        if(!$disallow_logs) $log->logMessage('Backup of <strong>'.$this->alias.' ('.$this->prefid.')</strong> successfully created.', E_MESSAGE_DEBUG, E_MESSAGE_SUCCESS, $session_messages);

Avoid deeply nested control flow statements.

Open

                        if(deftrue('e_DEBUG_PREFS'))
                        {
                            $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS,2);
                            $log->logMessage(print_a($backtrace,true),  E_MESSAGE_DEBUG);
                        }

Avoid deeply nested control flow statements.

Open

                        if(deftrue('e_DEBUG_PREFS'))
                        {
                            $backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS,2);
                            $log->logMessage(print_a($backtrace,true),  E_MESSAGE_DEBUG);
                        }

Avoid too many return statements within this method.

Open

            return false;

Avoid too many return statements within this method.

Open

            return 0;

Returning type false but get() is declared to return string

Open

            return false;

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param string val -- pre-serialized string': after string, did not see an element name (will guess based on comment order)

Open

    * @param  string val -- pre-serialized string

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (oldArray) is array but \e_admin_log::addArray() takes null defined at /code/e107_handlers/admin_log_class.php:790

Open

                        $log->addArray($new,$old);

• Exclude checks
  • Disable engine
  • Disable check

$$name[] expression may not be PHP 7 compatible

Open

                $$name[$key] = $tp->toDB($prefvalue);

• Exclude checks
  • Disable engine
  • Disable check

Argument 2 (MaximumAge) is 1440 but \ecache::retrieve_sys() takes bool|false defined at /code/e107_handlers/cache_handler.php:213

Open

            $this->pref_cache = e107::getCache()->retrieve_sys('Config_'.$this->alias, 24 * 60, true);

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (logLevel) is 'success' but \e_admin_log::logMessage() takes bool|int|true defined at /code/e107_handlers/admin_log_class.php:670

Open

                        if(!$disallow_logs) $log->logMessage('Backup of <strong>'.$this->alias.' ('.$this->prefid.')</strong> successfully created.', E_MESSAGE_DEBUG, E_MESSAGE_SUCCESS, $session_messages);

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but getConfigId() is declared to return string

Open

        return false;

• Exclude checks
  • Disable engine
  • Disable check

Argument 1 (options) is null but \debug_backtrace() takes bool|int

Open

                    $log->addWarning(print_r(debug_backtrace(null,2), true), false);

• Exclude checks
  • Disable engine
  • Disable check

Returning type false but get() is declared to return string

Open

                return false;

• Exclude checks
  • Disable engine
  • Disable check