e107inc/e107

Method user_extended_add has 12 arguments (exceeds 7 allowed). Consider refactoring.

Open

    function user_extended_add($name, $text='', $type='', $parms='', $values='', $default='', $required='', $read='', $write='', $applicable='', $order='', $parent='')

Method user_extended_modify has 12 arguments (exceeds 7 allowed). Consider refactoring.

Open

    function user_extended_modify($id, $name, $text, $type, $parms, $values, $default, $required, $read, $write, $applicable, $parent)

Consider simplifying this complex logical expression.

Open

            if (($category == 0) || ($isSignup && (int) $this->catDefinitions[$category]['user_extended_struct_applicable'] === (int) e_UC_MEMBER && (int) $this->catDefinitions[$category]['user_extended_struct_write'] === (int) e_UC_MEMBER) || (check_class($this->catDefinitions[$category]['user_extended_struct_applicable']) && check_class($this->catDefinitions[$category]['user_extended_struct_write'])))
            {    // Category applicable to user
                
                if (($isSignup && (int) $defs['user_extended_struct_applicable'] === (int) e_UC_MEMBER && (int) $defs['user_extended_struct_write'] === (int) e_UC_MEMBER) || (check_class($defs['user_extended_struct_applicable']) && check_class($defs['user_extended_struct_write'])))
                {    // User can also update field

Avoid too many return statements within this method.

Open

                return e107::getForm()->checkboxes($fname.'[]',$choices, $curval, array('useLabelValues'=>1));

Avoid too many return statements within this method.

Open

                        return e107::getForm()->text($fname,$curval,10,$opts);

Avoid too many return statements within this method.

Open

                    return "<textarea id='{$fid}' {$include} name='{$fname}'  {$required} {$title}>{$curval}</textarea>";

Avoid too many return statements within this method.

Open

                    return $ret;

Avoid too many return statements within this method.

Open

                    return "<span class='label label-danger'>Failed to load</span>";

Avoid too many return statements within this method.

Open

              return $ret;

Avoid too many return statements within this method.

Open

                return $ret;

Avoid too many return statements within this method.

Open

                    return e107::getForm()->datepicker($fname,$curval,$opts);

Avoid too many return statements within this method.

Open

                    return "Missing Extended Class";

Avoid too many return statements within this method.

Open

                    return "<span class='label label-danger'>Failed to load (misconfigured. See debug for more info.)</span>";

Avoid too many return statements within this method.

Open

                    return e107::getForm()->bbarea($fname, $curval);

Avoid too many return statements within this method.

Open

        return $ret;

Reference to undeclared constant \EUF_RADIO

Open

            'radio'         => EUF_RADIO,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

            'checkbox'        => EUF_CHECKBOX,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_COUNTRY

Open

                case EUF_COUNTRY:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_COUNTRY

Open

            case EUF_COUNTRY:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

            case EUF_CHECKBOX : //checkboxes

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

            case EUF_TEXTAREA : //textarea

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

            'text'          => EUF_TEXT,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

                    case EUF_LANGUAGE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

            case EUF_DATE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

                case EUF_CHECKBOX : //checkboxes

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

            case EUF_LANGUAGE : // language

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

            'date'          => EUF_DATE,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

            case EUF_RICHTEXTAREA :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

            case EUF_PREDEFINED :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

            case EUF_INTEGER :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

            'user_extended_struct_values'       => ($type === EUF_ADDON) ? (string) $values : (string) $tp -> toDB($values, true),

• Exclude checks
  • Disable engine
  • Disable check

Variable $ret was undeclared, but array fields are being added to it.

Open

        $ret['version'] = $data['@attributes']['version'];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

                    case EUF_TEXT :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

                    case EUF_TEXTAREA :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

        case EUF_INTEGER :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREFIELD

Open

         case EUF_PREFIELD: // FIXME Predefined field - this should be assignable from XML typically.

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

      if($type != EUF_DB_FIELD && ($type != EUF_TEXTAREA) && ($type != EUF_RICHTEXTAREA) &&  ($type != EUF_CHECKBOX) && !empty($default))

• Exclude checks
  • Disable engine
  • Disable check

array to string conversion

Open

        if($this->user_extended_field_exist($name) && $sql->field('user_extended', 'user_'.$name)!==false)

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

            case EUF_DATE : //date

• Exclude checks
  • Disable engine
  • Disable check

Variable $info is undeclared

Open

        unset($info);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

            'integer'       => EUF_INTEGER,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

            'language'      => EUF_LANGUAGE,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

            'richtextarea'     => EUF_RICHTEXTAREA, 

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param string read|write|applicable': after string, did not see an element name (will guess based on comment order)

Open

     * @param string read|write|applicable

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

            case EUF_DATE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

                    case EUF_CHECKBOX :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

                case EUF_DROPDOWN : //dropdown

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::db_getList

Open

                $ret = $sql->db_getList();

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_COUNTRY

Open

          case EUF_COUNTRY :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

            case EUF_DROPDOWN : //dropdown

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

            'db field'      => EUF_DB_FIELD,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

            'list'          => EUF_PREDEFINED,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREFIELD

Open

            'predefined'    => EUF_PREFIELD, // DON'T USE IT IN PREDEFINED FIELD XML!!! Used in plugin installation routine.

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

                    case EUF_DB_FIELD :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

                    case EUF_PREDEFINED :

• Exclude checks
  • Disable engine
  • Disable check

array to string conversion

Open

        trigger_error("Extended User Field ".$name." doesn't exist", E_USER_NOTICE);

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

            case EUF_RICHTEXTAREA : // rich textarea (using WYSIWYG editor)

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

            case EUF_TEXT :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

        case EUF_RADIO :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

            'textarea'      => EUF_TEXTAREA,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

            case EUF_CHECKBOX :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

                    case EUF_RADIO :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

                case EUF_TEXT :  //textbox

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

                case EUF_TEXTAREA : //textarea

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

      if($type != EUF_DB_FIELD && ($type != EUF_TEXTAREA) && ($type != EUF_RICHTEXTAREA) &&  ($type != EUF_CHECKBOX) && !empty($default))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

            case EUF_ADDON:

• Exclude checks
  • Disable engine
  • Disable check

Argument 4 (options) is array{label:mixed,required:bool} but \e_form::radio() takes null defined at /code/e107_handlers/form_handler.php:2928

Open

                        $ret .= $frm->radio($fname,$val,($curval == $val),array('label'=>$label, 'required'=> !empty($required)));

• Exclude checks
  • Disable engine
  • Disable check

Assigning array|array{default:0,name:mixed,text:string,type:mixed,values:mixed,required:mixed,read:mixed,write:mixed,applicable:mixed,include_text:mixed,parms:mixed,regex:mixed}[]|array{name:mixed,text:string,type:mixed,values:mixed,default:mixed,required:mixed,read:mixed,write:mixed,applicable:mixed,include_text:mixed,parms:mixed,regex:mixed}[]|array{version:string} to property but \e107_user_extended->extended_xml is false

Open

        $this->extended_xml = $ret;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

            'dropdown'      => EUF_DROPDOWN,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_COUNTRY

Open

            'country'       => EUF_COUNTRY,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

                    case EUF_RICHTEXTAREA :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

            case EUF_DB_FIELD :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

                    case EUF_DROPDOWN :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

                    case EUF_DATE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

            case EUF_TEXT :  //textbox

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

                case EUF_INTEGER :  //integer

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

            case EUF_INTEGER :  //integer

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

                case EUF_PREDEFINED : // predefined list, shown in dropdown

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

            case EUF_PREDEFINED : // predefined list, shown in dropdown

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

                case EUF_DB_FIELD : //db_field

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::db_getList

Open

                    $choiceList = $sql->db_getList('ALL', false);

• Exclude checks
  • Disable engine
  • Disable check

string passed to foreach instead of array

Open

        foreach($data['item'] as $item)

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

                case EUF_LANGUAGE : // language

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREFIELD

Open

                case EUF_PREFIELD:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

        case EUF_CHECKBOX :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

      if($type != EUF_DB_FIELD && ($type != EUF_TEXTAREA) && ($type != EUF_RICHTEXTAREA) &&  ($type != EUF_CHECKBOX) && !empty($default))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXT

Open

        case EUF_TEXT :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

        case EUF_DROPDOWN :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

         case EUF_ADDON:

• Exclude checks
  • Disable engine
  • Disable check

Returning type ?string but renderElement() is declared to return array|string

Open

        return $ret;

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type false|string, found an array index of type '\x40attributes', but expected the index to be of type int

Open

        $ret['version'] = $data['@attributes']['version'];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DROPDOWN

Open

            case EUF_DROPDOWN :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

            case EUF_ADDON :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CATEGORY

Open

        case EUF_CATEGORY:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

            case EUF_LANGUAGE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

            case EUF_DB_FIELD : //db_field

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_INTEGER

Open

                    case EUF_INTEGER :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

        case EUF_DATE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

        case EUF_DB_FIELD :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_LANGUAGE

Open

        case EUF_LANGUAGE :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

        case EUF_PREDEFINED :

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but renderElement() is declared to return array|string

Open

                    return null;

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type false|string, found an array index of type 'item', but expected the index to be of type int

Open

        foreach($data['item'] as $item)

• Exclude checks
  • Disable engine
  • Disable check

Saw a token Phan may have failed to parse after '* @return boolean;': after boolean, saw ';'

Open

     * @return boolean;

• Exclude checks
  • Disable engine
  • Disable check

Call to undeclared method \e_db::escape

Open

                $newvalue = "'".$sql->escape($newvalue)."'";

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

            'addon'         => EUF_ADDON,

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

            case EUF_RADIO :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

                case EUF_DATE : //date

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

                case EUF_RICHTEXTAREA : // rich textarea (using WYSIWYG editor)

• Exclude checks
  • Disable engine
  • Disable check

Saw possibly unextractable annotation for a fragment of comment '* @param string read|write|type|values|parms|applicable': after string, did not see an element name (will guess based on comment order)

Open

     * @param string read|write|type|values|parms|applicable

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

        case EUF_TEXTAREA:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

        case EUF_RICHTEXTAREA :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

            case EUF_RADIO : //radio

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_TEXTAREA

Open

            case EUF_TEXTAREA :

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

                case EUF_RADIO : //radio

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

                case EUF_ADDON:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

      if($type != EUF_DB_FIELD && ($type != EUF_TEXTAREA) && ($type != EUF_RICHTEXTAREA) &&  ($type != EUF_CHECKBOX) && !empty($default))

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_ADDON

Open

        if($type === EUF_ADDON && !empty($fieldType))

• Exclude checks
  • Disable engine
  • Disable check

When fetching an array index from a value of type string, found an array index of type 'version', but expected the index to be of type int

Open

        $ret['version'] = $data['@attributes']['version'];

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_CHECKBOX

Open

            case EUF_CHECKBOX:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_COUNTRY

Open

            case EUF_COUNTRY:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RICHTEXTAREA

Open

            case EUF_RICHTEXTAREA:

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DATE

Open

            case EUF_DATE :        //check for 0000-00-00 in date field

• Exclude checks
  • Disable engine
  • Disable check

Unused result of a binary '.' operator

Open

            "Couldn't find extended field class: ".$table;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_PREDEFINED

Open

            case EUF_PREDEFINED :    // Predefined field - have to look up display string in relevant file

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_RADIO

Open

            case EUF_RADIO:

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but renderValue() is declared to return array|string

Open

                    return null;

• Exclude checks
  • Disable engine
  • Disable check

Reference to undeclared constant \EUF_DB_FIELD

Open

            case EUF_DB_FIELD :        // check for db_lookup type

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but renderValue() is declared to return array|string

Open

                    return null;

• Exclude checks
  • Disable engine
  • Disable check

Returning type null but renderValue() is declared to return array|string

Open

                        return null;

• Exclude checks
  • Disable engine
  • Disable check