e107inc/e107

View on GitHub
e107_plugins/alt_auth/extended_password_handler.php

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Avoid too many return statements within this method.
Open

        return PASSWORD_VALID;
Severity: Major
Found in e107_plugins/alt_auth/extended_password_handler.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return PASSWORD_INVALID;
    Severity: Major
    Found in e107_plugins/alt_auth/extended_password_handler.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              if ($stored_hash != $pwHash) return PASSWORD_INVALID;
      Severity: Major
      Found in e107_plugins/alt_auth/extended_password_handler.php - About 30 mins to fix

        Returning type true but CheckPassword() is declared to return string
        Open

                return PASSWORD_VALID;

        Returning type false but CheckPassword() is declared to return string
        Open

                if ($stored_hash != $pwHash) return PASSWORD_INVALID;

        Returning type false but CheckPassword() is declared to return string
        Open

                            return PASSWORD_INVALID;

        Returning type false but CheckPassword() is declared to return string
        Open

                        return PASSWORD_INVALID;

        Returning type false but CheckPassword() is declared to return string
        Open

                            return PASSWORD_INVALID;

        Variable $setting is undeclared
        Open

                $output = substr($setting, 0, 12);        // Identifier, shift count and salt - total 12 chars

        Returning type false but CheckPassword() is declared to return string
        Open

                        if (strlen($stored_hash) != 40) return PASSWORD_INVALID;

        Returning type false but CheckPassword() is declared to return string
        Open

                        if (strlen($stored_hash) != 34) return PASSWORD_INVALID;

        There are no issues that match your filters.

        Category
        Status