Sign upLogin

e107inc/e107

View on GitHub
Star
e107_plugins/banner/admin_banner.php

Summary

Maintainability
A
0 mins
Test Coverage
F
20%

Argument 3 (previewURL) is null but \banner_form_ui::imagepicker() takes string defined at /code/e107_handlers/form_handler.php:1349
Open

                $tab1 = $this->imagepicker('banner_image',$val1, null, $opts);
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Argument 2 (fname) is true but \e107::lan() takes string defined at /code/e107_handlers/e107_class.php:3987
Open

e107::lan('banner',true);
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Assigning array<string></string> to property but \banner_ui->fields is array{checkboxes:array{title:'',type:null,data:null,width:'5%',thclass:'center',forced:'1',class:'center',toggle:'e-multiselect'},banner_id:array{title:'ID',type:null,data:'int',width:'2%',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_campaign:array{title:'Campaign',type:'method',data:'str',width:'auto',inline:false,filter:true,help:'',readParms:'',writeParms:array{tdClassRight:'form-inline'},class:'left',thclass:'left'},banner_clientname:array{title:'Client',type:'method',tab:1,data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clientlogin:array{title:'Client Login',type:'method',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_clientpassword:array{title:'Password',type:'text',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'strength=1&password=1&required=0&generate=1&nomask=1',class:'center',thclass:'center'},banner_image:array{title:'Image',type:'method',data:'str',width:'auto',help:'',readParms:'thumb=0x50&legacyPath=\x7be_IMAGE\x7dbanners',writeParms:'media=banner&w=600&legacyPath=\x7be_IMAGE\x7dbanners',class:'left',thclass:'left'},banner_clickurl:array{title:'Click URL',type:'text',data:'str',width:'auto',inline:true,help:'',readParms:'',writeParms:'size=xxlarge&required=1',class:'left',thclass:'left'},banner_impurchased:array{title:'Number of impressions purchased',type:'number',data:'int',width:'auto',inline:true,readParms:'',writeParms:'',class:'center',thclass:'center',help:'0 = unlimited'},banner_tooltip:array{title:'Tooltip',type:'text',data:'str',width:'auto',help:'',readParms:'',writeParms:array{size:'xxlarge'},class:'center',thclass:'center'},banner_description:array{title:'Description',type:'textarea',data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_keywords:array{title:'Keywords',type:'tags',data:'str',width:'auto',inline:true,help:'When news or pages are loaded, this will limit banner result to matching keywords. Use with caution.',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_startdate:array{title:'Start',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_enddate:array{title:'End',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_active:array{title:'Visibility',type:'userclass',data:'int',width:'auto',filter:true,batch:true,inline:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clicks:array{title:'Clickthroughs',type:'number',noedit:true,readonly:2,data:'int',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},click_percentage:array{title:'Click %',type:'method',noedit:true,data:false,width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_impressions:array{title:'Impressions',type:'method',noedit:true,data:'int',width:'12%',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_ip:array{title:'IP',type:'hidden',noedit:true,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},options:array{title:'Options',type:null,data:null,width:'10%',thclass:'center last',class:'center last',forced:'1'}}
Open

            $this->fields['banner_campaign']['type'] = 'text';
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Assigning array<string></string> to property but \banner_ui->fields is array{checkboxes:array{title:'',type:null,data:null,width:'5%',thclass:'center',forced:'1',class:'center',toggle:'e-multiselect'},banner_id:array{title:'ID',type:null,data:'int',width:'2%',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_campaign:array{title:'Campaign',type:'method',data:'str',width:'auto',inline:false,filter:true,help:'',readParms:'',writeParms:array{tdClassRight:'form-inline'},class:'left',thclass:'left'},banner_clientname:array{title:'Client',type:'method',tab:1,data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clientlogin:array{title:'Client Login',type:'method',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_clientpassword:array{title:'Password',type:'text',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'strength=1&password=1&required=0&generate=1&nomask=1',class:'center',thclass:'center'},banner_image:array{title:'Image',type:'method',data:'str',width:'auto',help:'',readParms:'thumb=0x50&legacyPath=\x7be_IMAGE\x7dbanners',writeParms:'media=banner&w=600&legacyPath=\x7be_IMAGE\x7dbanners',class:'left',thclass:'left'},banner_clickurl:array{title:'Click URL',type:'text',data:'str',width:'auto',inline:true,help:'',readParms:'',writeParms:'size=xxlarge&required=1',class:'left',thclass:'left'},banner_impurchased:array{title:'Number of impressions purchased',type:'number',data:'int',width:'auto',inline:true,readParms:'',writeParms:'',class:'center',thclass:'center',help:'0 = unlimited'},banner_tooltip:array{title:'Tooltip',type:'text',data:'str',width:'auto',help:'',readParms:'',writeParms:array{size:'xxlarge'},class:'center',thclass:'center'},banner_description:array{title:'Description',type:'textarea',data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_keywords:array{title:'Keywords',type:'tags',data:'str',width:'auto',inline:true,help:'When news or pages are loaded, this will limit banner result to matching keywords. Use with caution.',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_startdate:array{title:'Start',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_enddate:array{title:'End',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_active:array{title:'Visibility',type:'userclass',data:'int',width:'auto',filter:true,batch:true,inline:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clicks:array{title:'Clickthroughs',type:'number',noedit:true,readonly:2,data:'int',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},click_percentage:array{title:'Click %',type:'method',noedit:true,data:false,width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_impressions:array{title:'Impressions',type:'method',noedit:true,data:'int',width:'12%',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_ip:array{title:'IP',type:'hidden',noedit:true,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},options:array{title:'Options',type:null,data:null,width:'10%',thclass:'center last',class:'center last',forced:'1'}}
Open

            $this->fields['banner_campaign']['inline'] = true;
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Returning type array{caption:'Help',text:string} but renderHelp() is declared to return string
Open

            return array('caption' => LAN_HELP, 'text' => $help_text);
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Call to deprecated function \getperms() defined at /code/class2.php:1322
Open

if (!getperms('D') && !getperms('P'))
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Assigning array<string></string> to property but \banner_ui->fields is array{checkboxes:array{title:'',type:null,data:null,width:'5%',thclass:'center',forced:'1',class:'center',toggle:'e-multiselect'},banner_id:array{title:'ID',type:null,data:'int',width:'2%',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_campaign:array{title:'Campaign',type:'method',data:'str',width:'auto',inline:false,filter:true,help:'',readParms:'',writeParms:array{tdClassRight:'form-inline'},class:'left',thclass:'left'},banner_clientname:array{title:'Client',type:'method',tab:1,data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clientlogin:array{title:'Client Login',type:'method',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_clientpassword:array{title:'Password',type:'text',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'strength=1&password=1&required=0&generate=1&nomask=1',class:'center',thclass:'center'},banner_image:array{title:'Image',type:'method',data:'str',width:'auto',help:'',readParms:'thumb=0x50&legacyPath=\x7be_IMAGE\x7dbanners',writeParms:'media=banner&w=600&legacyPath=\x7be_IMAGE\x7dbanners',class:'left',thclass:'left'},banner_clickurl:array{title:'Click URL',type:'text',data:'str',width:'auto',inline:true,help:'',readParms:'',writeParms:'size=xxlarge&required=1',class:'left',thclass:'left'},banner_impurchased:array{title:'Number of impressions purchased',type:'number',data:'int',width:'auto',inline:true,readParms:'',writeParms:'',class:'center',thclass:'center',help:'0 = unlimited'},banner_tooltip:array{title:'Tooltip',type:'text',data:'str',width:'auto',help:'',readParms:'',writeParms:array{size:'xxlarge'},class:'center',thclass:'center'},banner_description:array{title:'Description',type:'textarea',data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_keywords:array{title:'Keywords',type:'tags',data:'str',width:'auto',inline:true,help:'When news or pages are loaded, this will limit banner result to matching keywords. Use with caution.',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_startdate:array{title:'Start',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_enddate:array{title:'End',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_active:array{title:'Visibility',type:'userclass',data:'int',width:'auto',filter:true,batch:true,inline:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clicks:array{title:'Clickthroughs',type:'number',noedit:true,readonly:2,data:'int',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},click_percentage:array{title:'Click %',type:'method',noedit:true,data:false,width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_impressions:array{title:'Impressions',type:'method',noedit:true,data:'int',width:'12%',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_ip:array{title:'IP',type:'hidden',noedit:true,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},options:array{title:'Options',type:null,data:null,width:'10%',thclass:'center last',class:'center last',forced:'1'}}
Open

            $this->fields['banner_campaign']['inline'] = true;
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Assigning array<string></string> to property but \banner_ui->fields is array{checkboxes:array{title:'',type:null,data:null,width:'5%',thclass:'center',forced:'1',class:'center',toggle:'e-multiselect'},banner_id:array{title:'ID',type:null,data:'int',width:'2%',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_campaign:array{title:'Campaign',type:'method',data:'str',width:'auto',inline:false,filter:true,help:'',readParms:'',writeParms:array{tdClassRight:'form-inline'},class:'left',thclass:'left'},banner_clientname:array{title:'Client',type:'method',tab:1,data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clientlogin:array{title:'Client Login',type:'method',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_clientpassword:array{title:'Password',type:'text',tab:1,data:'str',width:'auto',help:'',readParms:'',writeParms:'strength=1&password=1&required=0&generate=1&nomask=1',class:'center',thclass:'center'},banner_image:array{title:'Image',type:'method',data:'str',width:'auto',help:'',readParms:'thumb=0x50&legacyPath=\x7be_IMAGE\x7dbanners',writeParms:'media=banner&w=600&legacyPath=\x7be_IMAGE\x7dbanners',class:'left',thclass:'left'},banner_clickurl:array{title:'Click URL',type:'text',data:'str',width:'auto',inline:true,help:'',readParms:'',writeParms:'size=xxlarge&required=1',class:'left',thclass:'left'},banner_impurchased:array{title:'Number of impressions purchased',type:'number',data:'int',width:'auto',inline:true,readParms:'',writeParms:'',class:'center',thclass:'center',help:'0 = unlimited'},banner_tooltip:array{title:'Tooltip',type:'text',data:'str',width:'auto',help:'',readParms:'',writeParms:array{size:'xxlarge'},class:'center',thclass:'center'},banner_description:array{title:'Description',type:'textarea',data:'str',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_keywords:array{title:'Keywords',type:'tags',data:'str',width:'auto',inline:true,help:'When news or pages are loaded, this will limit banner result to matching keywords. Use with caution.',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_startdate:array{title:'Start',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_enddate:array{title:'End',type:'datestamp',tab:1,data:'int',width:'auto',filter:true,help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_active:array{title:'Visibility',type:'userclass',data:'int',width:'auto',filter:true,batch:true,inline:true,help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_clicks:array{title:'Clickthroughs',type:'number',noedit:true,readonly:2,data:'int',width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},click_percentage:array{title:'Click %',type:'method',noedit:true,data:false,width:'auto',help:'',readParms:'',writeParms:'',class:'center',thclass:'center'},banner_impressions:array{title:'Impressions',type:'method',noedit:true,data:'int',width:'12%',readParms:'',writeParms:'',class:'left',thclass:'left'},banner_ip:array{title:'IP',type:'hidden',noedit:true,data:'str',width:'auto',help:'',readParms:'',writeParms:'',class:'left',thclass:'left'},options:array{title:'Options',type:null,data:null,width:'10%',thclass:'center last',class:'center last',forced:'1'}}
Open

            $this->fields['banner_campaign']['type'] = 'text';
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

Argument 2 (default) is null but \banner_form_ui::imagepicker() takes string defined at /code/e107_handlers/form_handler.php:1349
Open

                $tab1 = $this->imagepicker('banner_image',$val1, null, $opts);
Severity: Minor
Found in e107_plugins/banner/admin_banner.php by phan

There are no issues that match your filters.

Category
Status