e107inc/e107

Avoid deeply nested control flow statements.

Open

                                if($tmp[0] == $mirror_id)
                                {
                                    $gaddress = trim($address);
                                    $requests++;
                                }

Avoid deeply nested control flow statements.

Open

                            if($tmp[0] == $mirror_id)
                            {
                                $gaddress = trim($address);
                                $requests++;
                            }

Consider simplifying this complex logical expression.

Open

                    if((!strpos($pref['download_denied'], ".php") &&
                        !strpos($pref['download_denied'], ".htm") &&
                        !strpos($pref['download_denied'], ".html") &&
                        !strpos($pref['download_denied'], ".shtml") ||
                        (strpos($pref['download_denied'], "signup.php") && USER == true)

Argument #1 of this call to \str_replace is typically a literal or constant but isn't, but argument #3 (which is typically a variable) is a literal or constant. The arguments may be in the wrong order.

Open

                        e107::getRender()->tablerender(LAN_ERROR, "<div class='alert alert-warning' style='text-align:center'>" . str_replace($search, $replace, LAN_dl_78) . '</div>');

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (row) is null but \e107::url() takes array defined at /code/e107_handlers/e107_class.php:4225

Open

                    $goUrl = e107::url('download', 'index', null, array('query'=>array('action'=>'error','id'=>2)));

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (row) is null but \e107::url() takes array defined at /code/e107_handlers/e107_class.php:4225

Open

                $goUrl = e107::url('download', 'index', null, array('query' => array('action' => 'error', 'id' => 1))); // ."?action=error&id=1";

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (row) is null but \e107::url() takes array defined at /code/e107_handlers/e107_class.php:4225

Open

                    $goUrl = e107::url('download', 'index', null, array('query'=>array('action'=>'error','id'=>2)));

• Exclude checks
  • Disable engine
  • Disable check

Argument 3 (row) is null but \e107::url() takes array defined at /code/e107_handlers/e107_class.php:4225

Open

                        $goUrl = e107::url('download', 'index', null, array('query' => array('action' => 'error', 'id' => 1)));

• Exclude checks
  • Disable engine
  • Disable check