e107inc/e107

View on GitHub
e107_plugins/forum/forum_update.php

Summary

Maintainability
A
30 mins
Test Coverage
F
8%

Avoid too many return statements within this method.
Open

        return true;
Severity: Major
Found in e107_plugins/forum/forum_update.php - About 30 mins to fix

    Call to undeclared method \e_db::isTable
    Open

            if($sql->isTable($curTable) && $sql->isEmpty($curTable))
    Severity: Critical
    Found in e107_plugins/forum/forum_update.php by phan

    Argument 4 (noWhere) is 'default' but \e_db::select() takes bool|false defined at /code/e107_handlers/e_db_interface.php:265
    Open

                if($sql->select('forum_thread', 'thread_options', 'thread_id = ' . $threadId, 'default'))
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    Variable $var was undeclared, but array fields are being added to it.
    Open

        $var[1]['text'] = '1 - Permissions';
    Severity: Info
    Found in e107_plugins/forum/forum_update.php by phan

    Call to undeclared method \e_db::db_getList
    Open

            $forumList = $sql->db_getList();
    Severity: Critical
    Found in e107_plugins/forum/forum_update.php by phan

    Call to undeclared method \e_db::db_getList
    Open

            $threadList = $sql->db_getList();
    Severity: Critical
    Found in e107_plugins/forum/forum_update.php by phan

    Call to deprecated function \show_admin_menu() defined at /code/e107_admin/boot.php:354
    Open

        show_admin_menu('Forum Upgrade', $action, $var);
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    Variable $ns is undeclared
    Open

        $ns->tablerender('Forum Upgrade', $mes->render());
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    Call to deprecated function \getperms() defined at /code/class2.php:1322
    Open

    if(!getperms('P'))
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    Argument 4 (noWhere) is 'default' but \e_db::select() takes bool|false defined at /code/e107_handlers/e_db_interface.php:265
    Open

            if($sql->select('forum_t', '*', "thread_parent = {$threadId} OR thread_id = {$threadId}", 'default'))
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    Call to undeclared method \e_db::db_getList
    Open

                $threadData = $sql->db_getList();
    Severity: Critical
    Found in e107_plugins/forum/forum_update.php by phan

    Argument 1 (dir) is 'forum' but \e107plugin::refresh() takes int defined at /code/e107_handlers/plugin_class.php:4587
    Open

            e107::getPlugin()->refresh('forum');
    Severity: Minor
    Found in e107_plugins/forum/forum_update.php by phan

    There are no issues that match your filters.

    Category
    Status