Sign upLogin

eagletmt/comic_walker

View on GitHub
Star
lib/comic_walker/item_decoder/unknown.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method calculate_moves has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def calculate_moves(width, height, rect_width, rect_height, pattern)
        wcnt = width / rect_width
        hcnt = height / rect_height
        width %= rect_width
        height %= rect_height
Severity: Minor
Found in lib/comic_walker/item_decoder/unknown.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method calculate_moves has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def calculate_moves(width, height, rect_width, rect_height, pattern)
        wcnt = width / rect_width
        hcnt = height / rect_height
        width %= rect_width
        height %= rect_height
Severity: Major
Found in lib/comic_walker/item_decoder/unknown.rb - About 2 hrs to fix

    Method calculate_moves has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          def calculate_moves(width, height, rect_width, rect_height, pattern)
    Severity: Minor
    Found in lib/comic_walker/item_decoder/unknown.rb - About 35 mins to fix

      Method calcXCoordinateYRest_ has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def calcXCoordinateYRest_(a, f, b, e, d)
      Severity: Minor
      Found in lib/comic_walker/item_decoder/unknown.rb - About 35 mins to fix

        Method calcYCoordinateXRest_ has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def calcYCoordinateXRest_(a, f, b, e, d)
        Severity: Minor
        Found in lib/comic_walker/item_decoder/unknown.rb - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status