ecadlabs/go-tezos

View on GitHub

Showing 30 of 30 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

func (s *Service) TrustNetworkPoint(ctx context.Context, address string) error {
    req, err := s.Client.NewRequest(ctx, http.MethodGet, "/network/points/"+address+"/trust", nil)
    if err != nil {
        return err
    }
Severity: Major
Found in service.go and 3 other locations - About 55 mins to fix
service.go on lines 275..285
service.go on lines 289..299
service.go on lines 421..431

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method RPCClient.Do has 9 return statements (exceeds 4 allowed).
Open

func (c *RPCClient) Do(req *http.Request, v interface{}) (err error) {
    dumpRequest(c.log(), log.DebugLevel, req)

    client := &http.Client{
        Transport: c.transport(),
Severity: Major
Found in client.go - About 55 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *Service) MonitorNetworkPointLog(ctx context.Context, address string, results chan<- []*NetworkPointLogEntry) error {
        req, err := s.Client.NewRequest(ctx, http.MethodGet, "/network/points/"+address+"/log?monitor", nil)
        if err != nil {
            return err
        }
    Severity: Minor
    Found in service.go and 1 other location - About 50 mins to fix
    service.go on lines 335..342

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    type DelegationOperationElem struct {
        GenericOperationElem `yaml:",inline"`
        Source               string                      `json:"source" yaml:"source"`
        Fee                  *BigInt                     `json:"fee" yaml:"fee"`
        Counter              *BigInt                     `json:"counter" yaml:"counter"`
    Severity: Minor
    Found in operations.go and 1 other location - About 50 mins to fix
    operations.go on lines 271..285

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    type OriginationOperationElem struct {
        GenericOperationElem `yaml:",inline"`
        Source               string                       `json:"source" yaml:"source"`
        Fee                  *BigInt                      `json:"fee" yaml:"fee"`
        Counter              *BigInt                      `json:"counter" yaml:"counter"`
    Severity: Minor
    Found in operations.go and 1 other location - About 50 mins to fix
    operations.go on lines 324..338

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (s *Service) MonitorNetworkPeerLog(ctx context.Context, peerID string, results chan<- []*NetworkPeerLogEntry) error {
        req, err := s.Client.NewRequest(ctx, http.MethodGet, "/network/peers/"+peerID+"/log?monitor", nil)
        if err != nil {
            return err
        }
    Severity: Minor
    Found in service.go and 1 other location - About 50 mins to fix
    service.go on lines 481..488

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method Service.GetProposals has 6 return statements (exceeds 4 allowed).
    Open

    func (s *Service) GetProposals(ctx context.Context, chainID, blockID string) ([]*Proposal, error) {
        req, err := s.Client.NewRequest(ctx, http.MethodGet, "/chains/"+chainID+"/blocks/"+blockID+"/votes/proposals", nil)
        if err != nil {
            return nil, err
        }
    Severity: Major
    Found in service.go - About 40 mins to fix

      Method RPCClient.handleNormalResponse has 5 return statements (exceeds 4 allowed).
      Open

      func (c *RPCClient) handleNormalResponse(ctx context.Context, resp *http.Response, v interface{}) error {
          // Normal return
          typ := reflect.TypeOf(v)
      
          if typ.Kind() == reflect.Chan {
      Severity: Major
      Found in client.go - About 35 mins to fix

        Your code does not pass gofmt in 2 places. Go fmt your code!
        Open

        package tezos
        Severity: Minor
        Found in operations.go by gofmt

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package tezos
        Severity: Minor
        Found in utils.go by gofmt
        Severity
        Category
        Status
        Source
        Language