Sign upLogin

ece517-p3/expertiza

View on GitHub
Star
app/controllers/import_file_controller.rb

Summary

Maintainability
F
3 days
Test Coverage

Assignment Branch Condition size for import_from_hash is too high. [130.6/15]
Open

  def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
Severity: Minor
Found in app/controllers/import_file_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Assignment Branch Condition size for hash_rows_with_headers is too high. [84.84/15]
Open

  def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)
Severity: Minor
Found in app/controllers/import_file_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method import_from_hash has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
Severity: Minor
Found in app/controllers/import_file_controller.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for show is too high. [45.49/15]
Open

  def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)
Severity: Minor
Found in app/controllers/import_file_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Perceived complexity for import_from_hash is too high. [31/7]
Open

  def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
Severity: Minor
Found in app/controllers/import_file_controller.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method import_from_hash has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
Severity: Major
Found in app/controllers/import_file_controller.rb - About 4 hrs to fix

    Cyclomatic complexity for import_from_hash is too high. [25/6]
    Open

      def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
    Severity: Minor
    Found in app/controllers/import_file_controller.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Assignment Branch Condition size for import is too high. [28.65/15]
    Open

      def import
    errors = import_from_hash(session, params)
    err_msg = "The following errors were encountered during import.
              <br/>Other records may have been added.
              A second submission will not duplicate these records.<br/><ul>"
    Severity: Minor
    Found in app/controllers/import_file_controller.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Perceived complexity for hash_rows_with_headers is too high. [19/7]
    Open

      def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)
    Severity: Minor
    Found in app/controllers/import_file_controller.rb by rubocop

    This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

    Example:

    def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

    Method hash_rows_with_headers has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)
    Severity: Minor
    Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity for hash_rows_with_headers is too high. [15/6]
    Open

      def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)
    Severity: Minor
    Found in app/controllers/import_file_controller.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method hash_rows_with_headers has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)
    Severity: Major
    Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

      File import_file_controller.rb has 256 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      class ImportFileController < ApplicationController
  def action_allowed?
    ['Instructor',
     'Teaching Assistant',
     'Administrator',
      Severity: Minor
      Found in app/controllers/import_file_controller.rb - About 2 hrs to fix

        Perceived complexity for show is too high. [11/7]
        Open

          def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb by rubocop

        This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

        Example:

        def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

        Cyclomatic complexity for show is too high. [9/6]
        Open

          def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb by rubocop

        This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

        An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

        Method has too many lines. [101/100]
        Open

          def import_from_hash(session, params)
    contents_hash = eval(params[:contents_hash])
    if params[:model] == "AssignmentTeam" or params[:model] == "CourseTeam"
      # contents_hash = eval(params[:contents_hash])
      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
        Severity: Minor
        Found in app/controllers/import_file_controller.rb by rubocop

        This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

        Method show has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method show has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def show
    @id = params[:id]
    @model = params[:model]
    @options = params[:options]
    @delimiter = get_delimiter(params)
        Severity: Minor
        Found in app/controllers/import_file_controller.rb - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                if params[:has_header] == 'true'
        @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      elsif params[:optional_count] == '0'
        new_header = [params[:select1], params[:select2], params[:select3]]
        @header_integrated_body = hash_rows_with_headers(new_header, contents_hash[:body])
          Severity: Major
          Found in app/controllers/import_file_controller.rb - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                  rescue StandardError
        errors << $ERROR_INFO
            Severity: Major
            Found in app/controllers/import_file_controller.rb - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                  elsif params[:model] == 'AssignmentParticipant' || params[:model] == 'CourseParticipant'
      # contents_hash = eval(params[:contents_hash])
      if params[:has_header] == 'true'
        @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      else
              Severity: Major
              Found in app/controllers/import_file_controller.rb - About 45 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      header.map!(&:to_sym)
      body.each do |row|
        h = {}
        if params[:has_reviewee] == "true_first"
          h[header[0]] = row.shift
                Severity: Major
                Found in app/controllers/import_file_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/import_file_controller.rb on lines 208..220

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      header.map!(&:to_sym)
      body.each do |row|
        h = {}
        if params[:has_teamname] == "true_first"
          h[header[0]] = row.shift
                Severity: Major
                Found in app/controllers/import_file_controller.rb and 1 other location - About 1 hr to fix
                app/controllers/import_file_controller.rb on lines 224..236

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 61.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []
      begin
        @header_integrated_body.each do |row_hash|
          MetareviewResponseMap.import(row_hash, session, params[:id])
                Severity: Minor
                Found in app/controllers/import_file_controller.rb and 1 other location - About 25 mins to fix
                app/controllers/import_file_controller.rb on lines 102..109

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 29.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      @header_integrated_body = hash_rows_with_headers(contents_hash[:header], contents_hash[:body])
      errors = []
      begin
        @header_integrated_body.each do |row_hash|
          ReviewResponseMap.import(row_hash, session, params[:id])
                Severity: Minor
                Found in app/controllers/import_file_controller.rb and 1 other location - About 25 mins to fix
                app/controllers/import_file_controller.rb on lines 113..120

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 29.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                The use of eval is a serious security risk.
                Open

                          options = eval(params[:options])
                Severity: Minor
                Found in app/controllers/import_file_controller.rb by rubocop

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad

eval(something)
binding.eval(something)

                The use of eval is a serious security risk.
                Open

                    contents_hash = eval(params[:contents_hash])
                Severity: Minor
                Found in app/controllers/import_file_controller.rb by rubocop

                This cop checks for the use of Kernel#eval and Binding#eval.

                Example:

                # bad

eval(something)
binding.eval(something)

                There are no issues that match your filters.

                Category
                Status