Assignment Branch Condition size for action_allowed? is too high. [30.66/15] Open
def action_allowed?
# currently we only have a index method which shows all the submission records given a team_id
assignment_team = AssignmentTeam.find(params[:team_id])
assignment = Assignment.find(assignment_team.parent_id)
return true if ['Super-Administrator', 'Administrator'].include? current_role_name- Read upRead up
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Cyclomatic complexity for action_allowed? is too high. [7/6] Open
def action_allowed?
# currently we only have a index method which shows all the submission records given a team_id
assignment_team = AssignmentTeam.find(params[:team_id])
assignment = Assignment.find(assignment_team.parent_id)
return true if ['Super-Administrator', 'Administrator'].include? current_role_name- Read upRead up
- Exclude checks
This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.
An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.
Method action_allowed? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def action_allowed?
# currently we only have a index method which shows all the submission records given a team_id
assignment_team = AssignmentTeam.find(params[:team_id])
assignment = Assignment.find(assignment_team.parent_id)
return true if ['Super-Administrator', 'Administrator'].include? current_role_name- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
show, edit, update, destroy are not explicitly defined on the controller. Open
before_action :set_submission_record, only: %i[show edit update destroy]- Read upRead up
- Exclude checks
This cop checks that methods specified in the filter's only
or except options are explicitly defined in the controller.
You can specify methods of superclass or methods added by mixins on the filter, but these confuse developers. If you specify methods where are defined on another controller, you should define the filter in that controller.
Example:
# bad
class LoginController < ApplicationController
before_action :require_login, only: %i[index settings logout]
def index
end
end
# good
class LoginController < ApplicationController
before_action :require_login, only: %i[index settings logout]
def index
end
def settings
end
def logout
end
endLine is too long. [235/160] Open
return true if TaMapping.exists?(ta_id: current_user.id, course_id: assignment.course_id) && (TaMapping.where(course_id: assignment.course_id).include? TaMapping.where(ta_id: current_user.id, course_id: assignment.course_id).first)- Exclude checks