ece517-p3/expertiza

Class TreeDisplayController has 45 methods (exceeds 20 allowed). Consider refactoring.

Open

class TreeDisplayController < ApplicationController
  helper :application
  include SecurityHelper

  def action_allowed?

Assignment Branch Condition size for children_node_ng is too high. [23.62/15]

Open

  def children_node_ng
    flash[:error] = "Invalid JSON in the TreeList" unless json_valid? params[:reactParams][:child_nodes]
    child_nodes = child_nodes_from_params(params[:reactParams][:child_nodes])
    tmp_res = {}
    child_nodes.each do |node|

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File tree_display_controller.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.

Open

class TreeDisplayController < ApplicationController
  helper :application
  include SecurityHelper

  def action_allowed?

Rename is_user_instructor? to user_instructor?.

Open

  def is_user_instructor?(instructor_id)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Rename is_user_ta? to user_ta?.

Open

  def is_user_ta?(instructor_id, child)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end