Sign upLogin

ece517-p3/expertiza

View on GitHub
Star
app/models/instructor.rb

Summary

Maintainability
A
25 mins
Test Coverage

Mass assignment is not restricted using attr_accessible
Open

class Instructor < User
Severity: Critical
Found in app/models/instructor.rb by brakeman

This warning comes up if a model does not limit what attributes can be set through mass assignment.

In particular, this check looks for attr_accessible inside model definitions. If it is not found, this warning will be issued.

Brakeman also warns on use of attr_protected - especially since it was found to be vulnerable to bypass. Warnings for mass assignment on models using attr_protected will be reported, but at a lower confidence level.

Note that disabling mass assignment globally will suppress these warnings.

Assignment Branch Condition size for get_user_list is too high. [19.21/15]
Open

  def self.get_user_list(user)
    participants = []
    user_list = []
    Course.where(instructor_id: user.id).find_each do |course|
      participants << course.get_participants
Severity: Minor
Found in app/models/instructor.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method get_user_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def self.get_user_list(user)
    participants = []
    user_list = []
    Course.where(instructor_id: user.id).find_each do |course|
      participants << course.get_participants
Severity: Minor
Found in app/models/instructor.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use find_by instead of where.first.
Open

    object_type.where("id = ? AND (instructor_id = ? OR private = 0)", id, user_id).first
Severity: Minor
Found in app/models/instructor.rb by rubocop

This cop is used to identify usages of where.first and change them to use find_by instead.

Example:

# bad
User.where(name: 'Bruce').first
User.where(name: 'Bruce').take

# good
User.find_by(name: 'Bruce')

Specify a :dependent option.
Open

  has_many :questionnaires
Severity: Minor
Found in app/models/instructor.rb by rubocop

This cop looks for has_many or has_one associations that don't specify a :dependent option. It doesn't register an offense if :through option was specified.

Example:

# bad
class User < ActiveRecord::Base
  has_many :comments
  has_one :avatar
end

# good
class User < ActiveRecord::Base
  has_many :comments, dependent: :restrict_with_exception
  has_one :avatar, dependent: :destroy
  has_many :patients, through: :appointments
end

Useless assignment to variable - instructor. Did you mean instructor_id?
Open

    instructor = Instructor.find(instructor_id)
Severity: Minor
Found in app/models/instructor.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status