Block has too many lines. [180/25]

Open

describe GradesController do
  let(:review_response) { build(:response) }
  let(:assignment) { build(:assignment, id: 1, questionnaires: [review_questionnaire], is_penalty_calculated: true) }
  let(:assignment_questionnaire) { build(:assignment_questionnaire, used_in_round: 1, assignment: assignment) }
  let(:participant) { build(:participant, id: 1, assignment: assignment, user_id: 1) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for list is too high. [110.1/15]

Open

  def list
    @automated_metareview = AutomatedMetareview.new
    # pass in the response id as a parameter
    @response = Response.find_by(map_id: params[:id])
    @automated_metareview.calculate_metareview_metrics(@response, params[:id])

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [173/25]

Open

  describe "topic_suggestion" do
    it "Instructor set an assignment which allow student suggest topic and register student2065" do
      # login as student2065, Note by Xing Pan: modify spec/factories/factories.rb to generate student11 and call "create student" at beginning
      user = User.find_by(name: 'student2064')
      stub_current_user(user, user.role.name, user.role)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [172/25]

Open

describe Response do
  let(:participant) { build(:participant, id: 1, user: build(:student, name: 'no name', fullname: 'no one')) }
  let(:participant2) { build(:participant, id: 2) }
  let(:assignment) { build(:assignment, id: 1, name: 'Test Assgt') }
  let(:team) { build(:assignment_team) }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for save_choices is too high. [107.1/15]

Open

  def save_choices(questionnaire_id)
    return unless params[:new_question] or params[:new_choices]
    questions = Question.where(questionnaire_id: questionnaire_id)
    question_num = 1

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for impersonate is too high. [102.4/15]

Open

  def impersonate
    if params[:user]
      message = "No user exists with the name '#{params[:user][:name]}'."
    elsif params[:impersonate]
      message = "No user exists with the name '#{params[:impersonate][:name]}'."

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for peer_review_strategy is too high. [98.49/15]

Open

  def peer_review_strategy(assignment_id, review_strategy, participants_hash)
    teams = review_strategy.teams
    participants = review_strategy.participants
    num_participants = participants.size

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [156/25]

Open

describe ReportsController do
  let(:assignment) { double('Assignment', id: 1) }
  let(:review_response_map) do
    double('ReviewResponseMap', id: 1, map_id: 1, assignment: assignment,
                                reviewer: double('Participant', id: 1, name: 'reviewer'), reviewee: double('Participant', id: 2, name: 'reviewee'))

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File assignment_creation_spec.rb has 625 lines of code (exceeds 250 allowed). Consider refactoring.

Open

def questionnaire_options(assignment, type, _round = 0)
  questionnaires = Questionnaire.where(['private = 0 or instructor_id = ?', assignment.instructor_id]).order('name')
  options = []
  questionnaires.select {|x| x.type == type }.each do |questionnaire|
    options << [questionnaire.name, questionnaire.id]

Assignment Branch Condition size for edit is too high. [90.14/15]

Open

  def edit(_count)
    html = '<td align="center"><a rel="nofollow" data-method="delete" href="/questions/' + self.id.to_s + '">Remove</a></td>'

    html += '<td><input size="6" value="' + self.seq.to_s + '" name="question[' + self.id.to_s + '][seq]"'
    html += ' id="question_' + self.id.to_s + '_seq" type="text"></td>'

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for summarize_reviews_by_reviewees is too high. [89.93/15]

Open

    def summarize_reviews_by_reviewees(assignment, summary_ws_url)
      # @summary[reviewee][round][question]
      # @reviewers[team][reviewer]
      # @avg_scores_by_reviewee[team]
      # @avg_score_round[reviewee][round]

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for merge_scores is too high. [87.87/15]

Open

  def merge_scores(scores)
    review_sym = "review".to_sym
    scores[review_sym] = {}
    scores[review_sym][:assessments] = []
    scores[review_sym][:scores] = {max: -999_999_999, min: 999_999_999, avg: 0}

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [141/25]

Open

describe MenuItem do
  ###
  # Use factories to `build` necessary objects.
  # Please avoid duplicated code as much as you can by moving the code to `before(:each)` block or separated methods.
  # RSpec tutorial video (until 9:32): https://youtu.be/dzkVfaKChSU?t=35s

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

File questionnaires_controller_spec.rb has 577 lines of code (exceeds 250 allowed). Consider refactoring.

Open

describe QuestionnairesController do
  let(:questionnaire) do
    build(id: 1, name: 'questionnaire', ta_id: 8, course_id: 1, private: false, min_question_score: 0, max_question_score: 5, type: 'ReviewQuestionnaire')
  end
  let(:questionnaire) { build(:questionnaire) }

Method get_questions_from_csv has a Cognitive Complexity of 62 (exceeds 5 allowed). Consider refactoring.

Open

  def self.get_questions_from_csv(questionnaire, file)
    questions = []
    custom_rubric = questionnaire.section == "Custom"

    CSV::Reader.parse(file) do |row|

• Read up
  Read up

Block has too many lines. [138/25]

Open

  describe "POST #children_node_ng for TA" do
    before(:each) do
      @treefolder = TreeFolder.new
      @treefolder.parent_id = nil
      @treefolder.name = "Courses"

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Assignment Branch Condition size for hash_rows_with_headers is too high. [84.84/15]

Open

  def hash_rows_with_headers(header, body)
    new_body = []
    if params[:model] == "User" or params[:model] == "AssignmentParticipant" or params[:model] == "CourseParticipant" or params[:model] == "SignUpTopic"
      # header.map! { |column_name| column_name.to_sym }
      header.map!(&:to_sym)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Module has too many lines. [123/100]

Open

module AssignmentHelper
  def course_options(instructor)
    if session[:user].role.name == 'Teaching Assistant'
      courses = []
      ta = Ta.find(session[:user].id)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Block has too many lines. [135/25]

Open

describe Menu do
  # To test menu, a variety of menu_items must exist.
  # role_admin.yml defines the permissionIds for admin as 5,5,6,3,2
  # we must assign controlleractions and contentpages
  # with permissionIds of those numbers

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Method peer_review_strategy has a Cognitive Complexity of 58 (exceeds 5 allowed). Consider refactoring.

Open

  def peer_review_strategy(assignment_id, review_strategy, participants_hash)
    teams = review_strategy.teams
    participants = review_strategy.participants
    num_participants = participants.size

• Read up
  Read up