Sign upLogin

ece517-p3/expertiza

View on GitHub
Star
spec/controllers/popup_controller_spec.rb

Summary

Maintainability
A
0 mins
Test Coverage

Block has too many lines. [56/25]
Open

describe PopupController do
  let(:team) { build(:assignment_team, id: 1, name: "team1", assignment: assignment) }
  let(:student) { build(:student, id: 1, name: "student") }
  let(:student2) { build(:student, id: 2, name: "student2") }
  let(:participant) { build(:participant, id: 1, user: student, assignment: assignment) }
Severity: Minor
Found in spec/controllers/popup_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [27/25]
Open

  describe "tone analysis tests" do
    before(:each) do
      allow(ReviewResponseMap).to receive(:where).with('reviewee_id = ?', team.id).and_return([response_map])
      allow(Assignment).to receive(:find).with('reviewee_id = ?', team.id).and_return(assignment)
      allow(ReviewResponseMap).to receive(:final_versions_from_reviewer).with(1).and_return(final_versions)
Severity: Minor
Found in spec/controllers/popup_controller_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Use underscores(_) as decimal mark and separate every 3 digits with them.
Open

    review_round_one: {questionnaire_id: 1, response_ids: [77024]},
Severity: Minor
Found in spec/controllers/popup_controller_spec.rb by rubocop

This cop checks for big numeric literals without _ between groups of digits in them.

Example:

# bad

1000000
1_00_000
1_0000

# good

1_000_000
1000

# good unless Strict is set

10_000_00 # typical representation of $10,000 in cents

There are no issues that match your filters.

Category
Status