ecoco/magento_profiler

View on GitHub
app/code/community/Ecocode/Profiler/Block/Collector/Time/Panel.php

Summary

Maintainability
A
1 hr
Test Coverage

Method getRequestJsonData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getRequestJsonData()
    {
        $eventList = $this->getCollector()->getEvents();
        $events = [];
        foreach ($eventList as $name => $event) {
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Block/Collector/Time/Panel.php - About 1 hr to fix

    Function getRequestJsonData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getRequestJsonData()
        {
            $eventList = $this->getCollector()->getEvents();
            $events = [];
            foreach ($eventList as $name => $event) {
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Block/Collector/Time/Panel.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid excessively long class names like Ecocode_Profiler_Block_Collector_Time_Panel. Keep class name length under 40.
    Open

    class Ecocode_Profiler_Block_Collector_Time_Panel
        extends Ecocode_Profiler_Block_Collector_Base
    {
        public function getRequestJsonData()
        {

    LongClassName

    Since: 2.9

    Detects when classes or interfaces are declared with excessively long names.

    Example

    class ATooLongClassNameThatHintsAtADesignProblem {
    
    }
    
    interface ATooLongInterfaceNameThatHintsAtADesignProblem {
    
    }

    Source https://phpmd.org/rules/naming.html#longclassname

    There are no issues that match your filters.

    Category
    Status