app/code/community/Ecocode/Profiler/Block/Profiler/Sidebar/Menu.php
Function getMenuBlocks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
Open
public function getMenuBlocks()
{
if (!$this->getProfile()) {
return [];
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid excessively long class names like Ecocode_Profiler_Block_Profiler_Sidebar_Menu. Keep class name length under 40. Open
Open
class Ecocode_Profiler_Block_Profiler_Sidebar_Menu extends Mage_Core_Block_Template
{
protected $profile = null;
public function getMenuBlocks()- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}