Sign upLogin

ecoco/magento_profiler

View on GitHub
Star
app/code/community/Ecocode/Profiler/Helper/ValueExporter.php

Summary

Maintainability
C
1 day
Test Coverage

Function exportValue has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public function exportValue($value, $depth = 1, $deep = false)
    {
        if (is_object($value)) {
            if ($value instanceof \DateTimeInterface) {
                return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ISO8601));
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exportValue has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function exportValue($value, $depth = 1, $deep = false)
    {
        if (is_object($value)) {
            if ($value instanceof \DateTimeInterface) {
                return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ISO8601));
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return $str;
    Severity: Major
    Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return 'null';
      Severity: Major
      Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return 'true';
        Severity: Major
        Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return (string)$value;
          Severity: Major
          Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return sprintf("[\n%s%s\n%s]", $indent, implode(sprintf(", \n%s", $indent), $all), str_repeat('  ', $depth - 1));
            Severity: Major
            Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'false';
              Severity: Major
              Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return sprintf("[\n%s%s\n]", $indent, implode(sprintf(",\n%s", $indent), $all));
                Severity: Major
                Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return sprintf('Resource(%s#%d)', get_resource_type($value), $value);
                  Severity: Major
                  Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

                    The method exportValue() has an NPath complexity of 2400. The configured NPath complexity threshold is 200.
                    Open

                        public function exportValue($value, $depth = 1, $deep = false)
    {
        if (is_object($value)) {
            if ($value instanceof \DateTimeInterface) {
                return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ISO8601));
                    Severity: Minor
                    Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php by phpmd

                    NPathComplexity

                    Since: 0.1

                    The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                    Example

                    class Foo {
    function bar() {
        // lots of complicated code
    }
}

                    Source https://phpmd.org/rules/codesize.html#npathcomplexity

                    The method exportValue() has a Cyclomatic Complexity of 14. The configured cyclomatic complexity threshold is 10.
                    Open

                        public function exportValue($value, $depth = 1, $deep = false)
    {
        if (is_object($value)) {
            if ($value instanceof \DateTimeInterface) {
                return sprintf('Object(%s) - %s', get_class($value), $value->format(\DateTime::ISO8601));
                    Severity: Minor
                    Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php by phpmd

                    CyclomaticComplexity

                    Since: 0.1

                    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                    Example

                    // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

                    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                    Missing class import via use statement (line '91', column '22').
                    Open

                            $array = new \ArrayObject($value);
                    Severity: Minor
                    Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php by phpmd

                    MissingImport

                    Since: 2.7.0

                    Importing all external classes in a file through use statements makes them clearly visible.

                    Example

                    function make() {
    return new \stdClass();
}

                    Source http://phpmd.org/rules/cleancode.html#MissingImport

                    There are no issues that match your filters.

                    Category
                    Status