app/code/community/Ecocode/Profiler/Model/Collector/CacheDataCollector.php
Method collectCacheCallData
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
protected function collectCacheCallData()
{
$cache = $this->getCacheInstance();
if (!$cache instanceof Ecocode_Profiler_Model_Core_Cache) {
return;
Function collectCacheCallData
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
protected function collectCacheCallData()
{
$cache = $this->getCacheInstance();
if (!$cache instanceof Ecocode_Profiler_Model_Core_Cache) {
return;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '46', column '39'). Open
Open
$backendOptionsProperty = new ReflectionProperty('Zend_Cache_Backend', '_options');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid excessively long variable names like $backendOptionsProperty. Keep variable name length under 20. Open
Open
$backendOptionsProperty = new ReflectionProperty('Zend_Cache_Backend', '_options');
- Read upRead up
- Exclude checks
LongVariable
Since: 0.2
Detects when a field, formal or local variable is declared with a long name.
Example
class Something {
protected $reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For
$interestingIntIndex < 10;
$interestingIntIndex++ ) {
}
}
}
Source https://phpmd.org/rules/naming.html#longvariable
Avoid excessively long class names like Ecocode_Profiler_Model_Collector_CacheDataCollector. Keep class name length under 40. Open
Open
class Ecocode_Profiler_Model_Collector_CacheDataCollector
extends Ecocode_Profiler_Model_Collector_AbstractDataCollector
implements Ecocode_Profiler_Model_Collector_LateDataCollectorInterface
{
/**
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}