Function collectTimingData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function collectTimingData()
{
$totalTime = 0;
foreach ($this->renderLog as &$data) {
$renderTimeExcl = $data['render_time_incl'];- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function beforeToHtml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
public function beforeToHtml(Varien_Event_Observer $observer)
{
/** @var Mage_Core_Block_Abstract $block */
$block = $observer->getEvent()->getData('block');
$id = uniqid();- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '66', column '33'). Open
$outputProperties = new ReflectionProperty('Mage_Core_Model_Layout', '_output');- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
Avoid assigning values to variables in if clauses and the like (line '25', column '13'). Open
public function beforeToHtml(Varien_Event_Observer $observer)
{
/** @var Mage_Core_Block_Abstract $block */
$block = $observer->getEvent()->getData('block');
$id = uniqid();- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '31', column '29'). Open
public function beforeToHtml(Varien_Event_Observer $observer)
{
/** @var Mage_Core_Block_Abstract $block */
$block = $observer->getEvent()->getData('block');
$id = uniqid();- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid excessively long class names like Ecocode_Profiler_Model_Collector_LayoutDataCollector. Keep class name length under 40. Open
class Ecocode_Profiler_Model_Collector_LayoutDataCollector
extends Ecocode_Profiler_Model_Collector_AbstractDataCollector
{
protected $renderLog = [];
protected $renderedBlocks = [];- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}