ecoco/magento_profiler

View on GitHub
app/code/community/Ecocode/Profiler/Model/Collector/LogDataCollector.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function sanitizeLogs has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    private function sanitizeLogs($logs)
    {
        $errorContextById = [];
        $sanitizedLogs    = [];

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sanitizeLogs has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function sanitizeLogs($logs)
    {
        $errorContextById = [];
        $sanitizedLogs    = [];

    Function computeErrorsCount has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        private function computeErrorsCount()
        {
            $logger = $this->getLogger();
            $count  = [
                'total_log_count'   => count($logger->getLogs()),

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method computeErrorsCount has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function computeErrorsCount()
        {
            $logger = $this->getLogger();
            $count  = [
                'total_log_count'   => count($logger->getLogs()),

      Avoid excessively long class names like Ecocode_Profiler_Model_Collector_LogDataCollector. Keep class name length under 40.
      Open

      class Ecocode_Profiler_Model_Collector_LogDataCollector
          extends Ecocode_Profiler_Model_Collector_AbstractDataCollector
          implements Ecocode_Profiler_Model_Collector_LateDataCollectorInterface
      {
          private $errorNames = [

      LongClassName

      Since: 2.9

      Detects when classes or interfaces are declared with excessively long names.

      Example

      class ATooLongClassNameThatHintsAtADesignProblem {
      
      }
      
      interface ATooLongInterfaceNameThatHintsAtADesignProblem {
      
      }

      Source https://phpmd.org/rules/naming.html#longclassname

      There are no issues that match your filters.

      Category
      Status