Sign upLogin

ecoco/magento_profiler

View on GitHub
Star
app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method collect has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function collect(Mage_Core_Controller_Request_Http $request, Mage_Core_Controller_Response_Http $response, \Exception $exception = null)
    {
        $stats = [
            'load'      => 0,
            'loop_load' => 0,
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php - About 1 hr to fix

    Function collect has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function collect(Mage_Core_Controller_Request_Http $request, Mage_Core_Controller_Response_Http $response, \Exception $exception = null)
    {
        $stats = [
            'load'      => 0,
            'loop_load' => 0,
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php - About 30 mins to fix

      Function getLoadLoopCalls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getLoadLoopCalls()
    {
        $traceHashList = [];

        foreach ($this->getCallLog() as $item) {
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid excessively long class names like Ecocode_Profiler_Model_Collector_ModelDataCollector. Keep class name length under 40.
      Open

      class Ecocode_Profiler_Model_Collector_ModelDataCollector
    extends Ecocode_Profiler_Model_Collector_AbstractDataCollector
{
    CONST LOAD_CALL_THRESHOLD = 20;
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/Model/Collector/ModelDataCollector.php by phpmd

      LongClassName

      Since: 2.9

      Detects when classes or interfaces are declared with excessively long names.

      Example

      class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

      Source https://phpmd.org/rules/naming.html#longclassname

      There are no issues that match your filters.

      Category
      Status