Sign upLogin

ecoco/magento_profiler

View on GitHub
Star
app/code/community/Ecocode/Profiler/Model/Profiler.php

Summary

Maintainability
A
1 hr
Test Coverage

Method find has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function find($ip, $url, $limit, $method, $start, $end)
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Model/Profiler.php - About 45 mins to fix

    Function getDataCollectors has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getDataCollectors()
    {
        if ($this->dataCollectors === null) {
            $contextCollector     = Mage::getSingleton('ecocode_profiler/collector_contextDataCollector');
            $this->dataCollectors = [];
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '150', column '23').
    Open

                throw new Exception('Unable to store the profiler information.', ['configured_storage' => get_class($this->storage)]);
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '92', column '24').
    Open

            $profile = new Ecocode_Profiler_Model_Profile(substr(hash('sha256', uniqid(mt_rand(), true)), 0, 6));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '181', column '26').
    Open

                $value = new \DateTime(is_numeric($value) ? '@' . $value : $value);
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '71', column '31').
    Open

                        throw new InvalidArgumentException('collector must implement "Ecocode_Profiler_Model_Collector_DataCollectorInterface"');
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status