Sign upLogin

ecoco/magento_profiler

View on GitHub
Star

Showing 241 of 241 total issues

Remove error control operator '@' on line 118.
Open

    public function fileExcerpt($file, $line)
    {
        if (is_readable($file)) {
            // highlight_file could throw warnings
            // see https://bugs.php.net/bug.php?id=25725
Severity: Minor
Found in app/code/community/Ecocode/Profiler/Helper/Code.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Remove error control operator '@' on line 69.
Open

    protected static function getNewLogger($channel)
    {
        if (!@class_exists('\Monolog\Logger')) {
            return new Ecocode_Profiler_Model_NullLogger();
        }
Severity: Minor
Found in app/code/community/Ecocode/Profiler/overwrite/Mage.php by phpmd

ErrorControlOperator

Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

Example

function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

Avoid too many return statements within this method.
Open

            return 'false';
Severity: Major
Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

    Missing class import via use statement (line '27', column '34').
    Open

                $reflector     = new ReflectionClass($data['class']);
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Block/Renderer/Context.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '302', column '20').
    Open

            return new Ecocode_Profiler_Model_Http_ParameterBag($this->data['request_cookies']);
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Collector/RequestDataCollector.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '145', column '23').
    Open

                throw new Exception(sprintf('Panel Block for "%s" is not available for token "%s".', $panel, $token));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/controllers/IndexController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '210', column '31').
    Open

                $userConfig = new stdClass();
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Config.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '43', column '23').
    Open

                throw new \Exception('missing "key" or "value"');
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/controllers/SettingsController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '141', column '23').
    Open

                throw new \InvalidArgumentException(sprintf('Format "%s" invalid (%s).', $format, implode(', ', [self::COOKIES_FLAT, self::COOKIES_ARRAY])));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Http/ResponseHeaderBag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '197', column '23').
    Open

                throw new \InvalidArgumentException('The filename and the fallback cannot contain the "/" and "\\" characters.');
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Http/ResponseHeaderBag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '15', column '31').
    Open

            $this->profiles = new \SplObjectStorage();
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Observer.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '92', column '24').
    Open

            $profile = new Ecocode_Profiler_Model_Profile(substr(hash('sha256', uniqid(mt_rand(), true)), 0, 6));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Profiler.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '148', column '23').
    Open

                throw new Exception(sprintf('Panel Block must extend "Ecocode_Profiler_Block_Collector_AbstractBase"'));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/controllers/IndexController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '178', column '23').
    Open

                throw new \InvalidArgumentException(sprintf('The disposition must be either "%s" or "%s".', self::DISPOSITION_ATTACHMENT, self::DISPOSITION_INLINE));
    Severity: Minor
    Found in app/code/community/Ecocode/Profiler/Model/Http/ResponseHeaderBag.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid too many return statements within this method.
    Open

                return sprintf("[\n%s%s\n]", $indent, implode(sprintf(",\n%s", $indent), $all));
    Severity: Major
    Found in app/code/community/Ecocode/Profiler/Helper/ValueExporter.php - About 30 mins to fix

      Missing class import via use statement (line '118', column '23').
      Open

                  throw new \LogicException(sprintf('Cant fetch event when the profiler is not started.'));
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/overwrite/VarienProfiler.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Remove error control operator '@' on line 46.
      Open

          public function dumpParameters(array $parameters)
    {
        if (!$parameters) {
            return '{}';
        }
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/Helper/Sql.php by phpmd

      ErrorControlOperator

      Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

      Example

      function foo($filePath) {
    $file = @fopen($filPath); // hides exceptions
    $key = @$array[$notExistingKey]; // assigns null to $key
}

      Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

      Missing class import via use statement (line '307', column '20').
      Open

              return new Ecocode_Profiler_Model_Http_ParameterBag($this->data['request_attributes']);
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/Model/Collector/RequestDataCollector.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '70', column '24').
      Open

                  return new Ecocode_Profiler_Model_NullLogger();
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/overwrite/Mage.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '19', column '37').
      Open

                  self::$autoloader = new Ecocode_Profiler_Autoloader();
      Severity: Minor
      Found in app/code/community/Ecocode/Profiler/autoloader.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Severity
      Category
      Status
      Source
      Language