edgewall/trac

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    Table('cache', key='id')[
        Column('id', type='int'),
        Column('generation', type='int'),
        Column('key')],

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    Table('enum', key=('type', 'name'))[
        Column('type'),
        Column('name'),
        Column('value'),
        Column('description')],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if pairs:
            revranges.a = pairs[0][0]
            revranges.b = pairs[-1][1]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if not egg_cache and options.get('TracEnvParentDir'):
                egg_cache = os.path.join(options.get('TracEnvParentDir'), '.egg-cache')

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if prev_version:
            add_link(req, 'prev', req.href.wiki(page.name, action='diff',
                                                version=prev_version),
                     _("Version %(num)s", num=prev_version))

• Read up
  Read up

Function enableCollapsibleColumns has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  $.fn.enableCollapsibleColumns = function(recovery_area) {
    // column headers
    var c_h_row = $('thead tr', this);
    var column_headers = $('th', c_h_row).not(recovery_area);
    var k = column_headers.length;

Function display_html has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def display_html(self, req, query):
        # The most recent query is stored in the user session;
        orig_list = None
        orig_time = datetime_now(utc)
        query_time = req.session.as_int('query_time', 0)

Function _insert_ticket_data has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    def _insert_ticket_data(self, req, ticket, data, author_id, field_changes):
        """Insert ticket data into the template `data`"""
        replyto = req.args.get('replyto')
        data['replyto'] = replyto
        data['version'] = ticket.resource.version

Function appendBatchListControls has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    function appendBatchListControls(td, propertyName, inputName) {
      var modeSelect = createSelect("batchmod_mode_" + propertyName,
                                    batch_list_modes).attr("id", inputName);
      var name1 = "batchmod_primary_" + propertyName;
      var name2 = "batchmod_secondary_" + propertyName;

Consider simplifying this complex logical expression.

Open

        if resource.realm == self.changeset_realm:
            parent = resource.parent
            return href.changeset(resource.id, parent and parent.id or None)
        elif resource.realm == self.source_realm:
            parent = resource.parent

Function _from_database has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def _from_database(self, id, sid, authenticated, distributor, format,

Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, section, name, interface, default=None,

Function init_db has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def init_db(self, path, schema=None, log=None, user=None, password=None,

Function __init__ has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, section, name, default=None, sep=',', keep_empty=False,

Function init_db has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def init_db(self, path, schema=None, log=None, user=None, password=None,

Function preview_data has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def preview_data(self, context, content, length, mimetype, filename,

Consider simplifying this complex logical expression.

Open

        if not ticket.exists and 'owner' not in updated:
            updated['owner'] = self._sub_owner_keyword(ticket['owner'], ticket)
        elif ticket['status'] == 'new' and \
                'component' in ticket.values and \
                'component' in ticket._old and \

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    Table('repository', key=('id', 'name'))[
        Column('id', type='int'),
        Column('name'),
        Column('value')],

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    tables = [Table('repository', key=('id', 'name'))[
                  Column('id', type='int'),
                  Column('name'),
                  Column('value')],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    if namelen < 128:
        namelen = _code2bytes(namelen)
    else:
        namelen = struct.pack('!L', namelen | 0x80000000)

• Read up
  Read up