File api.py has 1080 lines of code (exceeds 250 allowed). Consider refactoring.

Open

# -*- coding: utf-8 -*-
#
# Copyright (C) 2005-2023 Edgewall Software
# Copyright (C) 2005 Christopher Lenz <cmlenz@gmx.de>
# All rights reserved.

Function notify has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.

Open

    def notify(self, event, reponame, revs):
        """Notify repositories and change listeners about repository events.

        The supported events are the names of the methods defined in the
        `IRepositoryChangeListener` interface.

• Read up
  Read up

Function get_resource_description has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.

Open

    def get_resource_description(self, resource, format=None, **kwargs):
        if resource.realm == self.changeset_realm:
            parent = resource.parent
            reponame = parent and parent.id
            id = resource.id

• Read up
  Read up

Repository has 28 functions (exceeds 20 allowed). Consider refactoring.

Open

class Repository(object, metaclass=ABCMeta):
    """Base class for a repository provided by a version control system."""

    has_linear_changesets = False

Function modify_repository has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.

Open

    def modify_repository(self, reponame, changes):
        """Modify attributes of a repository."""
        if is_default(reponame):
            reponame = ''
        new_reponame = changes.get('name', reponame)

• Read up
  Read up

Function _get_connector has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.

Open

    def _get_connector(self, rtype):
        """Retrieve the appropriate connector for the given repository type.

        Note that the self._lock must be held when calling this method.
        """

• Read up
  Read up

RepositoryManager has 23 functions (exceeds 20 allowed). Consider refactoring.

Open

class RepositoryManager(Component):
    """Version control system manager."""

    implements(IRequestFilter, IResourceManager, IRepositoryProvider,
               ITemplateProvider)

Function get_all_repositories has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

    def get_all_repositories(self):
        """Return a dictionary of repository information, indexed by name."""
        if not self._all_repositories:
            all_repositories = {}
            for provider in self.providers:

• Read up
  Read up

Function pre_process_request has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

Open

    def pre_process_request(self, req, handler):
        if handler is not Chrome(self.env):
            for repo_info in self.get_all_repositories().values():
                if not as_bool(repo_info.get('sync_per_request')):
                    continue

• Read up
  Read up

Function get_repositories has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.

Open

    def get_repositories(self):
        """Retrieve repositories specified in TracIni.

        The `[repositories]` section can be used to specify a list
        of repositories.

• Read up
  Read up

Function resource_exists has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    def resource_exists(self, resource):
        if resource.realm == self.repository_realm:
            reponame = resource.id
        else:
            reponame = resource.parent.id

• Read up
  Read up

Function get_repositories_by_dir has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    def get_repositories_by_dir(self, directory):
        """Retrieve the repositories based on the given directory.

           :param directory: the key for identifying the repositories.
           :return: list of `Repository` instances.

• Read up
  Read up

Consider simplifying this complex logical expression.

Open

        if resource.realm == self.changeset_realm:
            parent = resource.parent
            return href.changeset(resource.id, parent and parent.id or None)
        elif resource.realm == self.source_realm:
            parent = resource.parent

Function get_repositories has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def get_repositories(self):
        """Retrieve repositories specified in the repository DB table."""
        repos = {}
        for id, name, value in self.env.db_query(
                "SELECT id, name, value FROM repository WHERE name IN (%s)"

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                        if 'id' not in info:
                            info['id'] = self.get_repository_id(reponame)
                        all_repositories[reponame] = info

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, repos, rev, message=None, author=None, date=None):

Function get_changes has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def get_changes(self, old_path, old_rev, new_path, new_rev,

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, repos, rev, message, author, date):

Function get_repository has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

    def get_repository(self, reponame):
        """Retrieve the appropriate `Repository` for the given
        repository name.

        :param reponame: the key for specifying the repository.

• Read up
  Read up

Avoid too many return statements within this function.

Open

            return True

Avoid too many return statements within this function.

Open

            return _("Repository %(repo)s", repo=resource.id)

Avoid too many return statements within this function.

Open

                return False

Function get_real_repositories has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    def get_real_repositories(self):
        """Return a sorted list of all real repositories (i.e. excluding
        aliases).
        """
        repositories = set()

• Read up
  Read up

Function get_repository_by_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    def get_repository_by_path(self, path):
        """Retrieve a matching `Repository` for the given `path`.

        :param path: the eventually scoped repository-scoped path
        :return: a `(reponame, repos, path)` triple, where `path` is

• Read up
  Read up

Function get_resource_url has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    def get_resource_url(self, resource, href, **kwargs):
        if resource.realm == self.changeset_realm:
            parent = resource.parent
            return href.changeset(resource.id, parent and parent.id or None)
        elif resource.realm == self.source_realm:

• Read up
  Read up