Sign upLogin

edgewall/trac

View on GitHub
Star
trac/versioncontrol/web_ui/util.py

Summary

Maintainability
D
2 days
Test Coverage

Function make_log_graph has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

def make_log_graph(repos, revs):
    """Generate graph information for the given revisions.

    Returns a tuple `(threads, vertices, columns)`, where:
Severity: Minor
Found in trac/versioncontrol/web_ui/util.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render_zip has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

def render_zip(req, filename, repos, root_node, iter_nodes):
    """Send a ZIP file containing the data corresponding to the `nodes`
    iterable.

    :type root_node: `~trac.versioncontrol.api.Node`
Severity: Minor
Found in trac/versioncontrol/web_ui/util.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_changes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

def get_changes(repos, revs, log=None):
    changes = {}
    for rev in revs:
        if rev in changes:
            continue
Severity: Minor
Found in trac/versioncontrol/web_ui/util.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if parent != parents[0]:
                            thread.append([0, col, line])
                        add_edge(thread, next_revs.index(parent), line + 1)
Severity: Major
Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

    Function get_path_links has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def get_path_links(href, reponame, path, rev, order=None, desc=None):
    Severity: Minor
    Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          with content_closing(
                            node.get_processed_content(eol_hint='CRLF')) \
                            as content:
                        data = content.read()
                    props = node.get_properties()
      Severity: Major
      Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if 'svn:executable' in props:
                        kwargs['executable'] = True
                elif node.isdir and path:
        Severity: Major
        Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if 'svn:special' in props and data.startswith('link '):
                        data = data[5:]
                        kwargs['symlink'] = True
                    if 'svn:executable' in props:
          Severity: Major
          Found in trac/versioncontrol/web_ui/util.py - About 45 mins to fix

            Function render_zip has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def render_zip(req, filename, repos, root_node, iter_nodes):
            Severity: Minor
            Found in trac/versioncontrol/web_ui/util.py - About 35 mins to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                  def write_partial(fileobj, start):
        end = fileobj.tell()
        fileobj.seek(start, 0)
        remaining = end - start
        while remaining > 0:
              Severity: Major
              Found in trac/versioncontrol/web_ui/util.py and 1 other location - About 5 hrs to fix
              trac/attachment.py on lines 499..508

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status