edgewall/trac

View on GitHub
trac/wiki/admin.py

Summary

Maintainability
C
1 day
Test Coverage

WikiAdmin has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class WikiAdmin(Component):
    """trac-admin command provider for wiki administration."""

    implements(IAdminCommandProvider, IEnvironmentSetupParticipant)

Severity: Minor
Found in trac/wiki/admin.py - About 2 hrs to fix

    Function _load_or_replace has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _load_or_replace(self, paths, replace):
            with self.env.db_transaction:
                for path in paths:
                    if os.path.isdir(path):
                        for page in sorted(os.listdir(path)):
    Severity: Minor
    Found in trac/wiki/admin.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function import_page has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def import_page(self, filename, title, create_only=[], replace=False):
            if filename:
                if not os.path.isfile(filename):
                    raise AdminCommandError(_("'%(name)s' is not a file",
                                              name=path_to_unicode(filename)))
    Severity: Minor
    Found in trac/wiki/admin.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _do_dump has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def _do_dump(self, directory, *names):
            if not names:
                names = ['*']
            pages = self.get_wiki_list()
            if not os.path.isdir(directory):
    Severity: Minor
    Found in trac/wiki/admin.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function load_pages has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def load_pages(self, dir, ignore=[], create_only=[], replace=False):
            loaded = []
            with self.env.db_transaction:
                for page in sorted(os.listdir(dir)):
                    if page in ignore:
    Severity: Minor
    Found in trac/wiki/admin.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function export_page has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def export_page(self, page, filename):
            wikipage = model.WikiPage(self.env, page)
            if wikipage.exists:
                if not filename:
                    printout(wikipage.text)
    Severity: Minor
    Found in trac/wiki/admin.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if os.path.isfile(filename):
                                self._import(filename, page, replace)
                    else:
    Severity: Major
    Found in trac/wiki/admin.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status