Sign upLogin

edtoken/redux-tide

View on GitHub
Star

Showing 16 of 16 total issues

Function makeAction has 94 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const makeAction = function(
  actionId,
  parentActionId,
  actionSchema,
  actionMethod,
Severity: Major
Found in src/action.js - About 3 hrs to fix

    File action.js has 304 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * @namespace action
 */

import {
    Severity: Minor
    Found in src/action.js - About 3 hrs to fix

      Function makeActionsReducer has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

      const makeActionsReducer = defaultActionsState => {
  return (state = defaultActionsState, action) => {
    if (!action.prefix || action.prefix !== ACTION_TYPE_PREFIX) {
      return state
    }
      Severity: Minor
      Found in src/reducer.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function makeActionsReducer has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const makeActionsReducer = defaultActionsState => {
  return (state = defaultActionsState, action) => {
    if (!action.prefix || action.prefix !== ACTION_TYPE_PREFIX) {
      return state
    }
      Severity: Major
      Found in src/reducer.js - About 2 hrs to fix

        Function makeEntitiesReducer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        const makeEntitiesReducer = defaultEntitiesState => {
  return function(state = defaultEntitiesState, action) {
    if (!action.prefix || action.prefix !== ACTION_TYPE_PREFIX) {
      return state
    }
        Severity: Minor
        Found in src/reducer.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function makeActionHandler has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const makeActionHandler = (
  Action,
  actionId,
  parentActionId,
  status,
        Severity: Minor
        Found in src/action.js - About 1 hr to fix

          Function action has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            this.action = (...args) => {
    this.responseMapper = responseMapper || getDefaultResponseMapper()

    const [pending, success, error] = STATUSES.map(statusName =>
      makeActionHandler(
          Severity: Minor
          Found in src/action.js - About 1 hr to fix

            Function _makeGetActionData has 36 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const _makeGetActionData = (action, actionId, entityName, actionSchema) => {
  return createSelector(
    [
      state => state[ACTIONS_REDUCER_NAME].get(actionId),
      state => state[ENTITIES_REDUCER_NAME].get(entityName),
            Severity: Minor
            Found in src/selector.js - About 1 hr to fix

              Function makeCallActionMethod has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              const makeCallActionMethod = resultCallBack => {
  return (actionMethod, args, dispatch, getState) => {
    args = Array.isArray(args) ? args : [args]

    let actionResult = actionMethod.apply(this, args)
              Severity: Minor
              Found in src/action.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function makeActionDenormalizedPayloads has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const makeActionDenormalizedPayloads = (
  isFetching,
  actionSchema,
  entities,
  payloadIsArray,
              Severity: Minor
              Found in src/selector.js - About 1 hr to fix

                Function makeEntitiesReducer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                const makeEntitiesReducer = defaultEntitiesState => {
  return function(state = defaultEntitiesState, action) {
    if (!action.prefix || action.prefix !== ACTION_TYPE_PREFIX) {
      return state
    }
                Severity: Minor
                Found in src/reducer.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      if (actionResult instanceof Promise) {
      return actionResult
        .then(resp => resultCallBack(dispatch, getState, false, resp))
        .catch(err => resultCallBack(dispatch, getState, err, undefined))
    }
                  Severity: Minor
                  Found in src/action.js and 1 other location - About 50 mins to fix
                  src/action.js on lines 222..226

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        if (actionResult instanceof Promise) {
        return actionResult
          .then(resp => resultCallBack(dispatch, getState, false, resp))
          .catch(err => resultCallBack(dispatch, getState, err, undefined))
      }
                  Severity: Minor
                  Found in src/action.js and 1 other location - About 50 mins to fix
                  src/action.js on lines 209..213

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function makeAction has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    actionId,
  parentActionId,
  actionSchema,
  actionMethod,
  queryBuilder,
                  Severity: Minor
                  Found in src/action.js - About 45 mins to fix

                    Function parseError has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export const parseError = err => {
  const typeOfError = typeof err

  if (err === false || typeOfError === 'undefined') {
    return false
                    Severity: Minor
                    Found in src/helper.js - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function makeActionDenormalizedPayloads has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    const makeActionDenormalizedPayloads = (
  isFetching,
  actionSchema,
  entities,
  payloadIsArray,
                    Severity: Minor
                    Found in src/selector.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language