Sign upLogin

eduardomoroni/trading-card-manager

View on GitHub
Star
packages/backend/db-migration/prisma/seed/card.ts

Summary

Maintainability
F
3 days
Test Coverage

Function addCard has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function addCard(card: any, set: any, skipRetry: boolean = false) {
  try {
    console.log(`Adding card ${card.name}`);
    const uuid: string = card.uuid;
    const data: CardCreateInput = {
Severity: Major
Found in packages/backend/db-migration/prisma/seed/card.ts - About 4 hrs to fix

    Function addCard has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function addCard(card: any, set: any, skipRetry: boolean = false) {
  try {
    console.log(`Adding card ${card.name}`);
    const uuid: string = card.uuid;
    const data: CardCreateInput = {
    Severity: Minor
    Found in packages/backend/db-migration/prisma/seed/card.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    async function addSubTypes(subTypes: Array<string> = []) {
  for (const subType of subTypes) {
    await prisma.createSubType({ name: subType }).catch(e => {
      console.log(`Failed to create sub type ${subType}`);
      console.log(JSON.stringify(e, null, 2));
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 3 hrs to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 123..130
    packages/backend/db-migration/prisma/seed/card.ts on lines 141..148
    packages/backend/db-migration/prisma/seed/card.ts on lines 150..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    async function addTypes(types: Array<string> = []) {
  for (const type of types) {
    await prisma.createType({ name: type }).catch(e => {
      console.log(`Failed to create type ${type}`);
      console.log(JSON.stringify(e, null, 2));
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 3 hrs to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 123..130
    packages/backend/db-migration/prisma/seed/card.ts on lines 132..139
    packages/backend/db-migration/prisma/seed/card.ts on lines 150..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    async function addPrinting(printings: Array<string> = []) {
  for (const printing of printings) {
    await prisma.createPrinting({ name: printing }).catch(e => {
      console.log(`Failed to create printing ${printing}`);
      console.log(JSON.stringify(e, null, 2));
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 3 hrs to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 132..139
    packages/backend/db-migration/prisma/seed/card.ts on lines 141..148
    packages/backend/db-migration/prisma/seed/card.ts on lines 150..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    async function addSuperTypes(superTypes: Array<string> = []) {
  for (const superType of superTypes) {
    await prisma.createSuperType({ name: superType }).catch(e => {
      console.log(`Failed to create super type ${superType}`);
      console.log(JSON.stringify(e, null, 2));
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 3 hrs to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 123..130
    packages/backend/db-migration/prisma/seed/card.ts on lines 132..139
    packages/backend/db-migration/prisma/seed/card.ts on lines 141..148

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if (
      errors.find((e: any) =>
        e.message.startsWith("No Node for the model Type with value")
      )
    ) {
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 1 hr to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 81..88
    packages/backend/db-migration/prisma/seed/card.ts on lines 89..96
    packages/backend/db-migration/prisma/seed/card.ts on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if (
      errors.find((e: any) =>
        e.message.startsWith("No Node for the model Printing with value")
      )
    ) {
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 1 hr to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 89..96
    packages/backend/db-migration/prisma/seed/card.ts on lines 97..104
    packages/backend/db-migration/prisma/seed/card.ts on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if (
      errors.find((e: any) =>
        e.message.startsWith("No Node for the model SubType with value")
      )
    ) {
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 1 hr to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 81..88
    packages/backend/db-migration/prisma/seed/card.ts on lines 97..104
    packages/backend/db-migration/prisma/seed/card.ts on lines 105..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if (
      errors.find((e: any) =>
        e.message.startsWith("No Node for the model SuperType with value")
      )
    ) {
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 1 hr to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 81..88
    packages/backend/db-migration/prisma/seed/card.ts on lines 89..96
    packages/backend/db-migration/prisma/seed/card.ts on lines 97..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          superTypes: {
        connect: <SuperType[]>card.supertypes.map((name: string) => ({ name }))
      },
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 30 mins to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 45..47
    packages/backend/db-migration/prisma/seed/card.ts on lines 48..50
    packages/backend/db-migration/prisma/seed/card.ts on lines 54..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          types: {
        connect: <Type[]>card.types.map((name: string) => ({ name }))
      }
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 30 mins to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 45..47
    packages/backend/db-migration/prisma/seed/card.ts on lines 48..50
    packages/backend/db-migration/prisma/seed/card.ts on lines 51..53

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          printings: {
        connect: <Printing[]>card.printings.map((name: string) => ({ name }))
      },
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 30 mins to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 48..50
    packages/backend/db-migration/prisma/seed/card.ts on lines 51..53
    packages/backend/db-migration/prisma/seed/card.ts on lines 54..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          subTypes: {
        connect: <SubType[]>card.subtypes.map((name: string) => ({ name }))
      },
    Severity: Major
    Found in packages/backend/db-migration/prisma/seed/card.ts and 3 other locations - About 30 mins to fix
    packages/backend/db-migration/prisma/seed/card.ts on lines 45..47
    packages/backend/db-migration/prisma/seed/card.ts on lines 51..53
    packages/backend/db-migration/prisma/seed/card.ts on lines 54..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status