Sign upLogin

educach/dsb-client

View on GitHub
Star

Showing 67 of 67 total issues

Function parseCurriculumXml has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
Open

    public static function parseCurriculumXml($curriculumXml, $variant = 'V_EF')
    {
        $reader = new Reader();

        // Prepare custom handlers for reading an XML node. See the Sabre\Xml
Severity: Minor
Found in src/Educa/DSB/Client/Curriculum/LP21Curriculum.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File ClientV2.php has 493 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * @file
 * Contains \Educa\DSB\Client\ApiClient\ClientV2.
Severity: Minor
Found in src/Educa/DSB/Client/ApiClient/ClientV2.php - About 7 hrs to fix

    Method parseCurriculumXml has 184 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function parseCurriculumXml($curriculumXml, $variant = 'V_EF')
    {
        $reader = new Reader();

        // Prepare custom handlers for reading an XML node. See the Sabre\Xml
    Severity: Major
    Found in src/Educa/DSB/Client/Curriculum/LP21Curriculum.php - About 7 hrs to fix

      Function fetchObjectivesAndProgressions has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function fetchObjectivesAndProgressions($url, $root, $dictionary, $objectiveIds)
    {
        if (preg_match('/\/$/', $url)) {
            $url = rtrim($url, '/');
        }
      Severity: Minor
      Found in src/Educa/DSB/Client/Curriculum/PerCurriculum.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File PerCurriculum.php has 369 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * @file
 * Contains \Educa\DSB\Client\Curriculum\PerCurriculum.
      Severity: Minor
      Found in src/Educa/DSB/Client/Curriculum/PerCurriculum.php - About 4 hrs to fix

        Function setTreeBasedOnTaxonPath has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
        Open

            public function setTreeBasedOnTaxonPath($paths, $purpose = 'discipline')
    {
        // Prepare a new root item.
        $this->root = $this->termFactory('root', 'root');
        Severity: Minor
        Found in src/Educa/DSB/Client/Curriculum/BaseCurriculum.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File LP21Curriculum.php has 352 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

/**
 * @file
 * Contains \Educa\DSB\Client\Curriculum\LP21Curriculum.
        Severity: Minor
        Found in src/Educa/DSB/Client/Curriculum/LP21Curriculum.php - About 4 hrs to fix

          Method fetchObjectivesAndProgressions has 100 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function fetchObjectivesAndProgressions($url, $root, $dictionary, $objectiveIds)
    {
        if (preg_match('/\/$/', $url)) {
            $url = rtrim($url, '/');
        }
          Severity: Major
          Found in src/Educa/DSB/Client/Curriculum/PerCurriculum.php - About 4 hrs to fix

            Function fetchDomainsAndDisciplines has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function fetchDomainsAndDisciplines($url, $root, $dictionary)
    {
        if (preg_match('/\/$/', $url)) {
            $url = rtrim($url, '/');
        }
            Severity: Minor
            Found in src/Educa/DSB/Client/Curriculum/PerCurriculum.php - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method fetchDomainsAndDisciplines has 74 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function fetchDomainsAndDisciplines($url, $root, $dictionary)
    {
        if (preg_match('/\/$/', $url)) {
            $url = rtrim($url, '/');
        }
            Severity: Major
            Found in src/Educa/DSB/Client/Curriculum/PerCurriculum.php - About 2 hrs to fix

              BaseTerm has 25 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class BaseTerm implements EditableTermInterface
{

    /**
     * The term's parent, if any.
              Severity: Minor
              Found in src/Educa/DSB/Client/Curriculum/Term/BaseTerm.php - About 2 hrs to fix

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        try {
            $response = $this->get('/search', $options);
            if ($response->getStatusCode() == 200) {
                return json_decode($response->getBody(), true);
            } else {
                Severity: Major
                Found in src/Educa/DSB/Client/ApiClient/ClientV2.php and 2 other locations - About 2 hrs to fix
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 148..165
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 403..420

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 138.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        try {
            $response = $this->post('/description', $params);
            if ($response->getStatusCode() == 200) {
                return json_decode($response->getBody(), true);
            } else {
                Severity: Major
                Found in src/Educa/DSB/Client/ApiClient/ClientV2.php and 2 other locations - About 2 hrs to fix
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 112..129
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 148..165

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 138.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        try {
            $response = $this->get('/suggest', $options);
            if ($response->getStatusCode() == 200) {
                return json_decode($response->getBody(), true);
            } else {
                Severity: Major
                Found in src/Educa/DSB/Client/ApiClient/ClientV2.php and 2 other locations - About 2 hrs to fix
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 112..129
                src/Educa/DSB/Client/ApiClient/ClientV2.php on lines 403..420

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 138.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method mapTerm has 69 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function mapTerm($source, $target, TermInterface $term)
    {
        if (
            ($source == 'educa' && $target == 'classification system') ||
            ($source == 'classification system' && $target == 'educa')
                Severity: Major
                Found in src/Educa/DSB/Client/Curriculum/ClassificationSystemCurriculum.php - About 2 hrs to fix

                  Function parseCurriculumJson has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static function parseCurriculumJson($curriculumJson)
    {
        $data = json_decode($curriculumJson);

        // Prepare the dictionary.
                  Severity: Minor
                  Found in src/Educa/DSB/Client/Curriculum/EducaCurriculum.php - About 2 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  ClientV2 has 21 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class ClientV2 extends AbstractClient
{

    protected $tokenExpiresOn;
                  Severity: Minor
                  Found in src/Educa/DSB/Client/ApiClient/ClientV2.php - About 2 hrs to fix

                    Method parseCurriculumJson has 50 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function parseCurriculumJson($curriculumJson)
    {
        $data = json_decode($curriculumJson);

        // Prepare the dictionary.
                    Severity: Minor
                    Found in src/Educa/DSB/Client/Curriculum/EducaCurriculum.php - About 2 hrs to fix

                      Function getContributorLogos has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function getContributorLogos()
    {
        $logos = array();
        $contributors = $this->getField('metaMetadata.contribute');
                      Severity: Minor
                      Found in src/Educa/DSB/Client/Lom/LomDescription.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method authenticate has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function authenticate()
    {
        if (!file_exists($this->privateKeyPath)) {
            throw new ClientAuthenticationException("Private key could not be loaded. Is the path correct ?");
        }
                      Severity: Minor
                      Found in src/Educa/DSB/Client/ApiClient/ClientV2.php - About 1 hr to fix
                        Severity
                        Category
                        Status
                        Source
                        Language