Showing 54 of 67 total issues
Function parseCurriculumXml
has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring. Open
public static function parseCurriculumXml($curriculumXml, $variant = 'V_EF')
{
$reader = new Reader();
// Prepare custom handlers for reading an XML node. See the Sabre\Xml
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ClientV2.php
has 493 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @file
* Contains \Educa\DSB\Client\ApiClient\ClientV2.
Method parseCurriculumXml
has 184 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function parseCurriculumXml($curriculumXml, $variant = 'V_EF')
{
$reader = new Reader();
// Prepare custom handlers for reading an XML node. See the Sabre\Xml
Function fetchObjectivesAndProgressions
has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring. Open
public static function fetchObjectivesAndProgressions($url, $root, $dictionary, $objectiveIds)
{
if (preg_match('/\/$/', $url)) {
$url = rtrim($url, '/');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File PerCurriculum.php
has 369 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @file
* Contains \Educa\DSB\Client\Curriculum\PerCurriculum.
Function setTreeBasedOnTaxonPath
has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring. Open
public function setTreeBasedOnTaxonPath($paths, $purpose = 'discipline')
{
// Prepare a new root item.
$this->root = $this->termFactory('root', 'root');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File LP21Curriculum.php
has 352 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* @file
* Contains \Educa\DSB\Client\Curriculum\LP21Curriculum.
Method fetchObjectivesAndProgressions
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function fetchObjectivesAndProgressions($url, $root, $dictionary, $objectiveIds)
{
if (preg_match('/\/$/', $url)) {
$url = rtrim($url, '/');
}
Function fetchDomainsAndDisciplines
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
public static function fetchDomainsAndDisciplines($url, $root, $dictionary)
{
if (preg_match('/\/$/', $url)) {
$url = rtrim($url, '/');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetchDomainsAndDisciplines
has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function fetchDomainsAndDisciplines($url, $root, $dictionary)
{
if (preg_match('/\/$/', $url)) {
$url = rtrim($url, '/');
}
BaseTerm
has 25 functions (exceeds 20 allowed). Consider refactoring. Open
class BaseTerm implements EditableTermInterface
{
/**
* The term's parent, if any.
Method mapTerm
has 69 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function mapTerm($source, $target, TermInterface $term)
{
if (
($source == 'educa' && $target == 'classification system') ||
($source == 'classification system' && $target == 'educa')
Function parseCurriculumJson
has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring. Open
public static function parseCurriculumJson($curriculumJson)
{
$data = json_decode($curriculumJson);
// Prepare the dictionary.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
ClientV2
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class ClientV2 extends AbstractClient
{
protected $tokenExpiresOn;
Method parseCurriculumJson
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function parseCurriculumJson($curriculumJson)
{
$data = json_decode($curriculumJson);
// Prepare the dictionary.
Function getContributorLogos
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
public function getContributorLogos()
{
$logos = array();
$contributors = $this->getField('metaMetadata.contribute');
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method authenticate
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function authenticate()
{
if (!file_exists($this->privateKeyPath)) {
throw new ClientAuthenticationException("Private key could not be loaded. Is the path correct ?");
}
Method describeDataStructure
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function describeDataStructure()
{
return array(
(object) array(
'type' => 'fachbereich',
Method postDescription
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function postDescription($json, $catalogs = array(), $previewImage = false)
{
if (empty($this->tokenKey)) {
throw new ClientAuthenticationException("No token found. Cannot create a LOM description without a token.");
}
Method setTreeBasedOnTaxonPath
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function setTreeBasedOnTaxonPath($paths, $purpose = 'discipline')
{
// Prepare a new root item.
$this->root = $this->termFactory('root', 'root');