Sign upLogin

education/classroom

View on GitHub
Star
lib/github_classroom/lti/message_store.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method message_valid? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def message_valid?(lti_message)
        # check for duplicate nonce
        return false if nonce_exists?(lti_message.oauth_nonce)

        # check if nonce too old
Severity: Minor
Found in lib/github_classroom/lti/message_store.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return false unless lti_message.resource_link_id
Severity: Major
Found in lib/github_classroom/lti/message_store.rb - About 30 mins to fix

    There are no issues that match your filters.

    Category
    Status