Sign upLogin

edwrodrig/template_composer_webapp

View on GitHub
Star

Showing 13 of 13 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    async create_user_clicked() {
        let form = this.create_user_form;
        let button = form.button('submit');

        let form_data = form.form_data;
Severity: Major
Found in data/modules/admin/users_screen.js and 2 other locations - About 6 hrs to fix
data/modules/admin/users_screen.js on lines 45..66
data/modules/admin/users_screen.js on lines 68..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    async set_user_type_clicked() {
        let form = this.set_user_type_form;
        let button = form.button('submit');

        let form_data = form.form_data;
Severity: Major
Found in data/modules/admin/users_screen.js and 2 other locations - About 6 hrs to fix
data/modules/admin/users_screen.js on lines 22..43
data/modules/admin/users_screen.js on lines 68..89

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    async set_user_password_clicked() {
        let form = this.set_user_password_form;
        let button = form.button('submit');

        let form_data = form.form_data;
Severity: Major
Found in data/modules/admin/users_screen.js and 2 other locations - About 6 hrs to fix
data/modules/admin/users_screen.js on lines 22..43
data/modules/admin/users_screen.js on lines 45..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 161.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

use labo86\staty_core\PagePhp;
use tpl_company_tpl\tpl_project_tpl\site\BlockPageWithLoading;
Severity: Major
Found in data/html/main.html.php and 1 other location - About 5 hrs to fix
data/html/admin.html.php on lines 1..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
declare(strict_types=1);

use labo86\staty_core\PagePhp;
use tpl_company_tpl\tpl_project_tpl\site\BlockPage;
Severity: Major
Found in data/html/admin.html.php and 1 other location - About 5 hrs to fix
data/html/main.html.php on lines 1..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function set_data has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    set_data(data) {
        this.controls.innerHTML = "";
        for ( let automatic_method of data ) {
            let button = document.createElement('A');
            button.classList.add('nav-link');
Severity: Minor
Found in data/modules/components/remote/SectionEasyServices.js - About 1 hr to fix

    Function create_form has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        create_form(data, on_success) {
        let form = new Form(document.createElement('FORM'));

        for ( let parameter of data.parameter_list ) {
            form.dom.appendChild(this.create_input_group(parameter.name, parameter.type));
    Severity: Minor
    Found in data/modules/components/remote/SectionEasyServices.js - About 1 hr to fix

      Function add_buttons has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          add_buttons(element) {
        let control = new class extends Element {

            get element_list() {
                return this.dom.querySelectorAll('[role="tab"]');
      Severity: Minor
      Found in data/modules/components/remote/TabConnector.js - About 1 hr to fix

        Function add_contents has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            add_contents(element) {
        let control = new class extends Element {

            get element_list() {
                let list = [];
        Severity: Minor
        Found in data/modules/components/remote/TabConnector.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function update_table has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async update_table() {
        let table = this.table;
        table.clear();

        try {
        Severity: Minor
        Found in data/modules/admin/errors_screen.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              set_status_ready() {
        let text = this.dom.getAttribute('data-ready-text');
        this.set_label(text);
        this.set_disabled(false);
    }
          Severity: Minor
          Found in data/modules/components/remote/Button.js and 1 other location - About 40 mins to fix
          data/modules/components/remote/Button.js on lines 12..16

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              set_status_waiting() {
        let text = this.dom.getAttribute('data-waiting-text');
        this.set_label(text);
        this.set_disabled(true);
    }
          Severity: Minor
          Found in data/modules/components/remote/Button.js and 1 other location - About 40 mins to fix
          data/modules/components/remote/Button.js on lines 18..22

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function add_buttons has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              add_buttons(element) {
        let control = new class extends Element {

            get element_list() {
                return this.dom.querySelectorAll('[role="tab"]');
          Severity: Minor
          Found in data/modules/components/remote/TabConnector.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language