eeeeeta/xmud

View on GitHub

Showing 4 of 4 total issues

Function loginPlayer has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        player.on('login', function loginPlayer() {
            player.question('What name do you go by in the realm of xMUD? ').then(function(answer) {
                player.socket.write('Aah, ' + answer + ', a nice name. Let me do a few checks...\n');
                if (answer.match(/^[a-z]+$/i) === null) {
                    player.socket.write('Hang on, that doesn\'t look like a name to me!\n');
Severity: Major
Found in login.js - About 2 hrs to fix

    Function signupPlayer has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            player.on('signup', function signupPlayer() {
                player.socket.write('That player doesn\'t seem to exist.\n');
                player.question('Would you like to create it? [y/n] ').then(function(answer) {
                    if (answer.toLowerCase().indexOf('y') == -1) {
                        throw new Error('Player creation canceled');
    Severity: Minor
    Found in login.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      process.log.error('error in signup! ' + error.message, {stack: error.stack, host: player.host, name: player.name});
      Severity: Minor
      Found in login.js and 1 other location - About 50 mins to fix
      login.js on lines 102..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          process.log.error('error in login! ' + thrown.message, {stack: thrown.stack, host: player.host, name: player.name});
      Severity: Minor
      Found in login.js and 1 other location - About 50 mins to fix
      login.js on lines 138..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language