efigence/cache_key_for

View on GitHub

Showing 85 of 85 total issues

Assignment Branch Condition size for cache_key_for is too high. [76.44/15]
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [44/10]
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method cache_key_for has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max
Severity: Minor
Found in lib/cache_key_for/cache_key_for_helper.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Perceived complexity for cache_key_for is too high. [19/7]
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Cyclomatic complexity for cache_key_for is too high. [14/6]
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Block has too many lines. [46/25]
Open

Gem::Specification.new do |s|
  s.name        = 'cache_key_for'
  s.version     = CacheKeyFor::VERSION.dup
  s.authors     = ['Marcin Kalita']
  s.email       = ['mkalita@efigence.com']
Severity: Minor
Found in cache_key_for.gemspec by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Method cache_key_for has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    # 1) paginated scope - `maximum/max` database query on page(2) does not work
    # 2) Array doesn't respond to `total_pages`
    max_updated_at = if scoped_collection.respond_to?(:total_pages) || scoped_collection.class == Array
      scoped_collection.to_a.map { |i| i.updated_at ? i.updated_at.utc.to_f : 0 }.max
Severity: Minor
Found in lib/cache_key_for/cache_key_for_helper.rb - About 1 hr to fix

    Method cache_key_for_view has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def cache_key_for_view(file, scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
    Severity: Major
    Found in lib/cache_key_for/cache_key_for_view_helper.rb - About 50 mins to fix

      Method cache_key_for has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})
      Severity: Minor
      Found in lib/cache_key_for/cache_key_for_helper.rb - About 45 mins to fix

        Avoid parameter lists longer than 5 parameters. [7/5]
        Open

          def cache_key_for_view(file, scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        Avoid parameter lists longer than 5 parameters. [6/5]
        Open

          def cache_key_for(scoped_collection, collection_prefix, cache_owner_cache_key = '', suffix = '', whitelist_params = [], default_params = {})

        This cop checks for methods with too many parameters. The maximum number of parameters is configurable. Keyword arguments can optionally be excluded from the total count.

        Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency fuubar should appear before pry-byebug.
        Open

          s.add_development_dependency('fuubar', '~> 2.0.0')
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Dependencies in the gemspec should be alphabetically sorted.

        Example:

        # bad
        spec.add_dependency 'rubocop'
        spec.add_dependency 'rspec'
        
        # good
        spec.add_dependency 'rspec'
        spec.add_dependency 'rubocop'
        
        # good
        spec.add_dependency 'rubocop'
        
        spec.add_dependency 'rspec'
        
        # bad
        spec.add_development_dependency 'rubocop'
        spec.add_development_dependency 'rspec'
        
        # good
        spec.add_development_dependency 'rspec'
        spec.add_development_dependency 'rubocop'
        
        # good
        spec.add_development_dependency 'rubocop'
        
        spec.add_development_dependency 'rspec'
        
        # bad
        spec.add_runtime_dependency 'rubocop'
        spec.add_runtime_dependency 'rspec'
        
        # good
        spec.add_runtime_dependency 'rspec'
        spec.add_runtime_dependency 'rubocop'
        
        # good
        spec.add_runtime_dependency 'rubocop'
        
        spec.add_runtime_dependency 'rspec'
        
        # good only if TreatCommentsAsGroupSeparators is true
        # For code quality
        spec.add_dependency 'rubocop'
        # For tests
        spec.add_dependency 'rspec'

        Line is too long. [150/120]
        Open

            digest = Digest::SHA1.hexdigest("#{ids_string}-#{max_updated_at}-#{count}-#{request.subdomains.join('.')}-#{request.path}-#{flat_request_params}")

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

                              "Rakefile",
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
        "No special symbols"
        "No string interpolation"
        "Just text"
        
        # good
        'No special symbols'
        'No string interpolation'
        'Just text'
        "Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
        'Just some text'
        'No special chars or interpolation'
        
        # good
        "Just some text"
        "No special chars or interpolation"
        "Every string in #{project} uses double_quotes"

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

                              "lib/cache_key_for/cache_key_for_helper.rb",
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
        "No special symbols"
        "No string interpolation"
        "Just text"
        
        # good
        'No special symbols'
        'No string interpolation'
        'Just text'
        "Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
        'Just some text'
        'No special chars or interpolation'
        
        # good
        "Just some text"
        "No special chars or interpolation"
        "Every string in #{project} uses double_quotes"

        Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency rspec-rails should appear before sqlite3.
        Open

          s.add_development_dependency('rspec-rails', '~> 3.1')
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Dependencies in the gemspec should be alphabetically sorted.

        Example:

        # bad
        spec.add_dependency 'rubocop'
        spec.add_dependency 'rspec'
        
        # good
        spec.add_dependency 'rspec'
        spec.add_dependency 'rubocop'
        
        # good
        spec.add_dependency 'rubocop'
        
        spec.add_dependency 'rspec'
        
        # bad
        spec.add_development_dependency 'rubocop'
        spec.add_development_dependency 'rspec'
        
        # good
        spec.add_development_dependency 'rspec'
        spec.add_development_dependency 'rubocop'
        
        # good
        spec.add_development_dependency 'rubocop'
        
        spec.add_development_dependency 'rspec'
        
        # bad
        spec.add_runtime_dependency 'rubocop'
        spec.add_runtime_dependency 'rspec'
        
        # good
        spec.add_runtime_dependency 'rspec'
        spec.add_runtime_dependency 'rubocop'
        
        # good
        spec.add_runtime_dependency 'rubocop'
        
        spec.add_runtime_dependency 'rspec'
        
        # good only if TreatCommentsAsGroupSeparators is true
        # For code quality
        spec.add_dependency 'rubocop'
        # For tests
        spec.add_dependency 'rspec'

        Do not use space inside array brackets.
        Open

          s.files         = [ ".gitignore",
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Checks that brackets used for array literals have or don't have surrounding space depending on configuration.

        Example: EnforcedStyle: space

        # The `space` style enforces that array literals have
        # surrounding space.
        
        # bad
        array = [a, b, c, d]
        
        # good
        array = [ a, b, c, d ]

        Example: EnforcedStyle: no_space

        # The `no_space` style enforces that array literals have
        # no surrounding space.
        
        # bad
        array = [ a, b, c, d ]
        
        # good
        array = [a, b, c, d]

        Example: EnforcedStyle: compact

        # The `compact` style normally requires a space inside
        # array brackets, with the exception that successive left
        # or right brackets are collapsed together in nested arrays.
        
        # bad
        array = [ a, [ b, c ] ]
        
        # good
        array = [ a, [ b, c ]]

        %q-literals should be delimited by ( and ).
        Open

          s.description = %q{How to design a perfect cache key? This project's goal is to provide a bulletproof solution for most use cases.}
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        This cop enforces the consistent usage of %-literal delimiters.

        Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

        Example:

        # Style/PercentLiteralDelimiters:
        #   PreferredDelimiters:
        #     default: '[]'
        #     '%i':    '()'
        
        # good
        %w[alpha beta] + %i(gamma delta)
        
        # bad
        %W(alpha #{beta})
        
        # bad
        %I(alpha beta)

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

            s.metadata['allowed_push_host'] = "https://rubygems.org"
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
        "No special symbols"
        "No string interpolation"
        "Just text"
        
        # good
        'No special symbols'
        'No string interpolation'
        'Just text'
        "Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
        'Just some text'
        'No special chars or interpolation'
        
        # good
        "Just some text"
        "No special chars or interpolation"
        "Every string in #{project} uses double_quotes"

        Prefer single-quoted strings when you don't need string interpolation or special symbols.
        Open

                              "cache_key_for.gemspec",
        Severity: Minor
        Found in cache_key_for.gemspec by rubocop

        Checks if uses of quotes match the configured preference.

        Example: EnforcedStyle: single_quotes (default)

        # bad
        "No special symbols"
        "No string interpolation"
        "Just text"
        
        # good
        'No special symbols'
        'No string interpolation'
        'Just text'
        "Wait! What's #{this}!"

        Example: EnforcedStyle: double_quotes

        # bad
        'Just some text'
        'No special chars or interpolation'
        
        # good
        "Just some text"
        "No special chars or interpolation"
        "Every string in #{project} uses double_quotes"
        Severity
        Category
        Status
        Source
        Language