Sign upLogin

efritz/chevron

View on GitHub
Star
middleware/cache.go

Summary

Maintainability
A
35 mins
Test Coverage

Method CacheMiddleware.Convert has 5 return statements (exceeds 4 allowed).
Open

func (m *CacheMiddleware) Convert(f chevron.Handler) (chevron.Handler, error) {
    handler := func(ctx context.Context, req *http.Request, logger nacelle.Logger) response.Response {
        // If we don't have a cache instance or if this request can
        // have side effects, do not attempt to touch the cache in
        // either direction.
Severity: Major
Found in middleware/cache.go - About 35 mins to fix

    TODO found
    Open

        // TODO - additional keys
    Severity: Minor
    Found in middleware/cache.go by fixme

    receiver name c should be consistent with previous receiver name m for CacheMiddleware
    Open

    func (c *CacheMiddleware) makeCacheKey(req *http.Request) string {
    Severity: Minor
    Found in middleware/cache.go by golint

    exported method CacheMiddleware.Convert should have comment or be unexported
    Open

    func (m *CacheMiddleware) Convert(f chevron.Handler) (chevron.Handler, error) {
    Severity: Minor
    Found in middleware/cache.go by golint

    receiver name c should be consistent with previous receiver name m for CacheMiddleware
    Open

    func (c *CacheMiddleware) generateCacheValue(
    Severity: Minor
    Found in middleware/cache.go by golint

    exported type CacheMiddleware should have comment or be unexported
    Open

    type CacheMiddleware struct {
    Severity: Minor
    Found in middleware/cache.go by golint

    There are no issues that match your filters.

    Category
    Status