efritz/derision

View on GitHub

Showing 43 of 43 total issues

Function makeHandler has 6 return statements (exceeds 4 allowed).
Open

func makeHandler(input []byte) (handler.Handler, error) {
    payload := &jsonHandler{}
    if err := json.Unmarshal(input, &payload); err != nil {
        return nil, fmt.Errorf("failed to unmarshal payload (%s)", err.Error())
    }
Severity: Major
Found in internal/server/serialization.go - About 40 mins to fix

    Function Unmarshal has 6 return statements (exceeds 4 allowed).
    Open

    func Unmarshal(payload []byte) (Expectation, error) {
        e := &jsonExpectation{}
        if err := json.Unmarshal(payload, &e); err != nil {
            return nil, fmt.Errorf("failed to unmarshal payload (%s)", err.Error())
        }
    Severity: Major
    Found in internal/expectation/serialization.go - About 40 mins to fix

      Function makeHandlersFromPath has 5 return statements (exceeds 4 allowed).
      Open

      func makeHandlersFromPath(schema *gojsonschema.Schema, segments ...string) ([]handler.Handler, error) {
          data, err := loadYAML(segments...)
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in internal/server/serialization.go - About 35 mins to fix

        Function Unmarshal has 5 return statements (exceeds 4 allowed).
        Open

        func Unmarshal(payload []byte) (Template, error) {
            t := &jsonTemplate{}
            if err := json.Unmarshal(payload, &t); err != nil {
                return nil, fmt.Errorf("failed to unmarshal payload (%s)", err.Error())
            }
        Severity: Major
        Found in internal/template/serialization.go - About 35 mins to fix

          Function setupDataStructures has 5 return statements (exceeds 4 allowed).
          Open

          func setupDataStructures(config nacelle.Config, services nacelle.ServiceContainer) error {
              serverConfig := &Config{}
              if err := config.Load(serverConfig); err != nil {
                  return err
              }
          Severity: Major
          Found in internal/server/server.go - About 35 mins to fix

            Method template.Respond has 5 return statements (exceeds 4 allowed).
            Open

            func (t *template) Respond(r *request.Request, m *expectation.Match) (response.Response, error) {
                args := map[string]interface{}{
                    "Method":       r.Method,
                    "Path":         r.Path,
                    "Headers":      r.Headers,
            Severity: Major
            Found in internal/template/template.go - About 35 mins to fix

              exported func NewLog returns unexported type *request.log, which can be annoying to use
              Open

              func NewLog(capacity int) *log {
              Severity: Minor
              Found in internal/request/log.go by golint

              exported type Request should have comment or be unexported
              Open

              type Request struct {
              Severity: Minor
              Found in internal/request/request.go by golint

              exported var ErrIllegalStatusCode should have comment or be unexported
              Open

              var ErrIllegalStatusCode = fmt.Errorf("illegal status code")
              Severity: Minor
              Found in internal/template/template.go by golint

              exported type Expectation should have comment or be unexported
              Open

                  Expectation interface {
              Severity: Minor
              Found in internal/expectation/expectation.go by golint

              exported type Handler should have comment or be unexported
              Open

              type Handler func(r *request.Request) (response.Response, error)
              Severity: Minor
              Found in internal/handler/handler.go by golint

              exported type Config should have comment or be unexported
              Open

              type Config struct {
              Severity: Minor
              Found in internal/server/config.go by golint

              exported method ControlMiddleware.Convert should have comment or be unexported
              Open

              func (m *ControlMiddleware) Convert(f chevron.Handler) (chevron.Handler, error) {
              Severity: Minor
              Found in internal/server/middleware.go by golint

              exported method SSEResource.Get should have comment or be unexported
              Open

              func (r *SSEResource) Get(ctx context.Context, req *http.Request, logger nacelle.Logger) response.Response {
              Severity: Minor
              Found in internal/server/resources.go by golint

              exported method Server.Stop should have comment or be unexported
              Open

              func (s *Server) Stop() error {
              Severity: Minor
              Found in internal/server/server.go by golint

              exported function NewHandlerSet should have comment or be unexported
              Open

              func NewHandlerSet() *handlerSet {
              Severity: Minor
              Found in internal/handler/set.go by golint

              exported type RequestsResource should have comment or be unexported
              Open

                  RequestsResource struct{ *BaseResource }
              Severity: Minor
              Found in internal/server/resources.go by golint

              exported function NewServer should have comment or be unexported
              Open

              func NewServer() *Server {
              Severity: Minor
              Found in internal/server/server.go by golint

              exported type Match should have comment or be unexported
              Open

                  Match struct {
              Severity: Minor
              Found in internal/expectation/expectation.go by golint

              exported function Unmarshal should have comment or be unexported
              Open

              func Unmarshal(payload []byte) (Expectation, error) {
              Severity
              Category
              Status
              Source
              Language