Showing 20 of 20 total issues
File main.go
has 614 lines of code (exceeds 500 allowed). Consider refactoring. Open
package main
import (
"fmt"
"log"
Similar blocks of code found in 2 locations. Consider refactoring. Open
package matchers
import (
"fmt"
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 286.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
package matchers
import (
"fmt"
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 286.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method generator.generateMockStructFromConstructor
has 51 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (g *generator) generateMockStructFromConstructor(iface *wrappedInterface) jen.Code {
ifaceName := jen.Qual(generation.SanitizeImportPath(iface.ImportPath, g.outputImportPath), iface.Name)
var surrogate *jen.Statement
if !unicode.IsUpper([]rune(iface.Name)[0]) {
Function getCallHistory
has 5 return statements (exceeds 4 allowed). Open
func getCallHistory(v interface{}) ([]callInstance, bool) {
value := reflect.ValueOf(v)
if !value.IsValid() {
return nil, false
}
exported type Empty should have comment or be unexported Open
type Empty interface{}
- Exclude checks
exported type Command should have comment or be unexported Open
type Command func() error
- Exclude checks
exported type Child should have comment or be unexported Open
type Child interface {
- Exclude checks
exported function BeCalled should have comment or be unexported Open
func BeCalled() types.GomegaMatcher {
- Exclude checks
exported type Parent should have comment or be unexported Open
type Parent interface {
- Exclude checks
exported type OptionValidator should have comment or be unexported Open
type OptionValidator interface {
- Exclude checks
exported function BeCalledOnceWith should have comment or be unexported Open
func BeCalledOnceWith(args ...interface{}) types.GomegaMatcher {
- Exclude checks
exported function BeCalledOnce should have comment or be unexported Open
func BeCalledOnce() types.GomegaMatcher {
- Exclude checks
exported function BeCalledWith should have comment or be unexported Open
func BeCalledWith(args ...interface{}) types.GomegaMatcher {
- Exclude checks
exported function BeAnything should have comment or be unexported Open
func BeAnything() types.GomegaMatcher {
- Exclude checks
2: cannot find package "github.com/dave/jennifer/jen" in any of: Open
"github.com/dave/jennifer/jen"
- Exclude checks
exported type Client should have comment or be unexported Open
type Client interface {
- Exclude checks
exported type Option should have comment or be unexported Open
type Option struct{}
- Exclude checks
exported type Retrier should have comment or be unexported Open
type Retrier interface {
- Exclude checks
exported function BeCalledN should have comment or be unexported Open
func BeCalledN(n int) types.GomegaMatcher {
- Exclude checks