Showing 348 of 348 total issues
Method runTaskRunner.Run has 5 return statements (exceeds 4 allowed). Open
func (r *runTaskRunner) Run(context *RunContext) bool {
r.logger.Info(
r.prefix,
"Beginning task",
)Method Loader.readConfigs has 5 return statements (exceeds 4 allowed). Open
func (l *Loader) readConfigs(path string) error {
if _, ok := l.loadedConfigs[path]; ok {
return nil
}
Function Validate has 5 return statements (exceeds 4 allowed). Open
func Validate(name string, data []byte) error {
schema, err := getSchema(name)
if err != nil {
return err
}Similar blocks of code found in 2 locations. Consider refactoring. Open
func (s *buildTaskCommandBuilderState) addLabelOptions(cb *command.Builder) error {
for _, label := range s.task.Labels {
expanded, err := s.env.ExpandString(label)
if err != nil {
return err- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (s *buildTaskCommandBuilderState) addTagOptions(cb *command.Builder) error {
for _, tag := range s.task.Tags {
expanded, err := s.env.ExpandString(tag)
if err != nil {
return err- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 102.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
exported method Builder.SetStdin should have comment or be unexported Open
func (b *Builder) SetStdin(rc io.ReadCloser) {- Exclude checks
exported method Options.Merge should have comment or be unexported Open
func (o *Options) Merge(child *Options) {- Exclude checks
exported method RemoveTask.MarshalJSON should have comment or be unexported Open
func (t *RemoveTask) MarshalJSON() ([]byte, error) {- Exclude checks
exported type TaskMeta should have comment or be unexported Open
TaskMeta struct {- Exclude checks
exported method Options.MarshalJSON should have comment or be unexported Open
func (o *Options) MarshalJSON() ([]byte, error) {- Exclude checks
exported type GCRRegistry should have comment or be unexported Open
GCRRegistry struct {- Exclude checks
exported method RemoveTask.GetType should have comment or be unexported Open
func (t *RemoveTask) GetType() string {- Exclude checks
exported type RunTask should have comment or be unexported Open
RunTask struct {- Exclude checks
exported type RunMode should have comment or be unexported Open
RunMode int- Exclude checks
exported function Default should have comment or be unexported Open
func Default() (Environment, error) {- Exclude checks
exported type Config should have comment or be unexported Open
Config struct {- Exclude checks
exported method Config.IsPlanDefined should have comment or be unexported Open
func (c *Config) IsPlanDefined(name string) bool {- Exclude checks
exported type PushTask should have comment or be unexported Open
type PushTask struct {- Exclude checks
exported method ServerRegistry.GetType should have comment or be unexported Open
func (r *ServerRegistry) GetType() string { return "server" }- Exclude checks
exported function NewTaskExtendsResolver should have comment or be unexported Open
func NewTaskExtendsResolver(config *Config) *TaskExtendsResolver {- Exclude checks