efritz/reception

View on GitHub

Showing 8 of 8 total issues

Method elector.Elect has 6 return statements (exceeds 4 allowed).
Open

func (e *elector) Elect() error {
    service, err := makeService(e.serviceID, e.name, e.host, e.port, e.attributes)
    if err != nil {
        return err
    }
Severity: Major
Found in election.go - About 40 mins to fix

    Method consulWatcher.Start has 5 return statements (exceeds 4 allowed).
    Open

    func (w *consulWatcher) Start() (<-chan *ServiceState, error) {
        ch := make(chan *ServiceState)
    
        go func() {
            defer close(ch)
    Severity: Major
    Found in consul.go - About 35 mins to fix

      Function getServerAddrs has 5 return statements (exceeds 4 allowed).
      Open

      func getServerAddrs(url string) ([]string, error) {
          req, err := http.NewRequest("GET", url, nil)
          if err != nil {
              return nil, err
          }
      Severity: Major
      Found in exhibitor.go - About 35 mins to fix

        Method zkWatcher.Start has 5 return statements (exceeds 4 allowed).
        Open

        func (w *zkWatcher) Start() (<-chan *ServiceState, error) {
            ch := make(chan *ServiceState)
        
            go func() {
                defer close(ch)
        Severity: Major
        Found in zk.go - About 35 mins to fix

          2: cannot find package "github.com/efritz/glock" in any of:
          Open

              "github.com/efritz/glock"
          Severity: Minor
          Found in check_server.go by govet

          exported function NewNilLogger should have comment or be unexported
          Open

          func NewNilLogger() Logger {
          Severity: Minor
          Found in logging.go by golint

          context.Context should be the first parameter of a function
          Open

          func (c *consulShim) Watch(name string, index uint64, ctx context.Context) ([]*consul.CatalogService, uint64, error) {
          Severity: Minor
          Found in consul_shim.go by golint

          exported type Elector should have comment or be unexported
          Open

              Elector interface {
          Severity: Minor
          Found in election.go by golint
          Severity
          Category
          Status
          Source
          Language