Sign upLogin

efureev/mu

View on GitHub
Star
src/object/equals.ts

Summary

Maintainability
F
3 days
Test Coverage

Function equal has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

export default function equal(origin: Record<PropertyKey, any>, ...list: Record<PropertyKey, any>[]): boolean {
  let i: number, l: number, leftChain: Array<any>, rightChain: Array<any>

  if (!isObject(origin) || list.length === 0) {
    throw new Error('Need two or more arguments to compare')
Severity: Minor
Found in src/object/equals.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function equal has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function equal(origin: Record<PropertyKey, any>, ...list: Record<PropertyKey, any>[]): boolean {
  let i: number, l: number, leftChain: Array<any>, rightChain: Array<any>

  if (!isObject(origin) || list.length === 0) {
    throw new Error('Need two or more arguments to compare')
Severity: Major
Found in src/object/equals.ts - About 3 hrs to fix

    Function compare2Objects has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function compare2Objects(x: any, y: any) {
    let p

    // remember that NaN === NaN returns false
    // and isNaN(undefined) returns true
    Severity: Major
    Found in src/object/equals.ts - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          if (
      (typeof x === 'function' && typeof y === 'function') ||
      (x instanceof Date && y instanceof Date) ||
      (x instanceof RegExp && y instanceof RegExp) ||
      (x instanceof String && y instanceof String) ||
      Severity: Critical
      Found in src/object/equals.ts - About 2 hrs to fix

        Avoid too many return statements within this function.
        Open

              return false
        Severity: Major
        Found in src/object/equals.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false
          Severity: Major
          Found in src/object/equals.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return false
            Severity: Major
            Found in src/object/equals.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return false
              Severity: Major
              Found in src/object/equals.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return false
                Severity: Major
                Found in src/object/equals.ts - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return false
                  Severity: Major
                  Found in src/object/equals.ts - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return false
                    Severity: Major
                    Found in src/object/equals.ts - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return false
                      Severity: Major
                      Found in src/object/equals.ts - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return false
                        Severity: Major
                        Found in src/object/equals.ts - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return false
                          Severity: Major
                          Found in src/object/equals.ts - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return true
                            Severity: Major
                            Found in src/object/equals.ts - About 30 mins to fix

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    if (Object.prototype.isPrototypeOf.call(y, p) !== Object.prototype.isPrototypeOf.call(x, p)) {
        return false
      } else if (typeof y[p] !== typeof x[p]) {
        return false
      }
                              Severity: Major
                              Found in src/object/equals.ts and 1 other location - About 2 hrs to fix
                              src/object/equals.ts on lines 68..72

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 75.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Identical blocks of code found in 2 locations. Consider refactoring.
                              Open

                                    if (Object.prototype.isPrototypeOf.call(y, p) !== Object.prototype.isPrototypeOf.call(x, p)) {
        return false
      } else if (typeof y[p] !== typeof x[p]) {
        return false
      }
                              Severity: Major
                              Found in src/object/equals.ts and 1 other location - About 2 hrs to fix
                              src/object/equals.ts on lines 76..80

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 75.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              There are no issues that match your filters.

                              Category
                              Status