efureev/yii2-tagsinput

View on GitHub

Showing 12 of 12 total issues

Avoid variables with short names like $js. Configured minimum length is 3.
Open

    public $js = [
        'dist/bootstrap-tagsinput.js'
    ];
Severity: Minor
Found in src/TagsInputAsset.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $js. Configured minimum length is 3.
Open

    public $js = [
        'dist/typeahead.bundle.min.js'
    ];
Severity: Minor
Found in src/TypeaheadAsset.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in src/TypeaheadAsset.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace efureev\tagsinput;
Severity: Minor
Found in src/TagsInputAsset.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in src/TagsInputAsset.php by phpcodesniffer

Avoid using static access to class '\yii\helpers\Json' in method 'registerScript'.
Open

        $clientOptions = empty($this->clientOptions) ? '' : Json::encode($this->clientOptions);
Severity: Minor
Found in src/TagsInput.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'efureev\tagsinput\TagsInputAsset' in method 'init'.
Open

        TagsInputAsset::register($this->getView());
Severity: Minor
Found in src/TagsInput.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\yii\helpers\Html' in method 'run'.
Open

            echo Html::activeInput('text', $this->model, $this->attribute, $this->options);
Severity: Minor
Found in src/TagsInput.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\yii\helpers\Html' in method 'run'.
Open

            echo Html::input('text', $this->name, $this->value, $this->options);
Severity: Minor
Found in src/TagsInput.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/TypeaheadAsset.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/TagsInputAsset.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/TagsInput.php by phpcodesniffer
Severity
Category
Status
Source
Language