Sign upLogin

eggplants/extension-manifest-converter

View on GitHub
Star
emc/lib/modifiers/InsertCssModifier.py

Summary

Maintainability
B
5 hrs
Test Coverage
F
57%

Function _mv3 has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def _mv3(self) -> None:
        needsChange = False
        for root, dirs, files in os.walk(self.wrapper.destination, topdown=False):
            for name in files:
                if str(Path(name).suffix) != ".js":
Severity: Minor
Found in emc/lib/modifiers/InsertCssModifier.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if data.find(seek) == -1:
                            continue
                        Logger().log("Changing to chrome.scripting.insertCSS")
Severity: Major
Found in emc/lib/modifiers/InsertCssModifier.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if not needsChange:
                            needsChange = True
                        file.seek(0)
    Severity: Major
    Found in emc/lib/modifiers/InsertCssModifier.py - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status