Sign upLogin

eggplants/extension-manifest-converter

View on GitHub
Star
emc/lib/modifiers/ServiceWorkerModifier.py

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Avoid deeply nested control flow statements.
Open

                        for line in infile:
                            outfile.write(line)
                    os.remove(scriptFile)
Severity: Major
Found in emc/lib/modifiers/ServiceWorkerModifier.py - About 45 mins to fix

    Function _mv3 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def _mv3(self) -> None:
        manifest = self.wrapper.manifest
        if "background" not in manifest or "scripts" not in manifest["background"]:
            return
        Logger().log("Changing to background.service_worker in manifest.json")
    Severity: Minor
    Found in emc/lib/modifiers/ServiceWorkerModifier.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status